From: ludovic.desroches@atmel•com (ludovic.desroches)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v11 4/4] G45 TWI: remove open drain setting for twi function gpios
Date: Mon, 27 Aug 2012 12:24:38 +0200 [thread overview]
Message-ID: <503B4AE6.4090107@atmel.com> (raw)
In-Reply-To: <6acdbd0f06cb9902efc510346564e10b07fa0b91.1345618760.git.n.voss@weinmann.de>
Hi Nikolaus,
Le 11/08/2011 12:11 PM, Nikolaus Voss a ?crit :
> The G45 datasheets explicitly states that setting the open drain property
> on peripheral function gpios is not allowed. (How about other A91 chips?)
>
Did you remove open drain because you had some issues or because you had
seen it into datasheet?
I tried with and without open drain. The behavior was the same. Looking
to the G45 datasheet, I didn't see that the open drain property is not
allowed on peripheral function gpios:
'The Multi Drive can be selected whether the I/O line
is controlled by the PIO controller or assigned to a peripheral function.'
The datasheet should have been updated or there is another place where
it is mentioned that open drain property is not allowed in this case.
Regards
Ludovic
> Signed-off-by: Nikolaus Voss <n.voss@weinmann•de>
> ---
> arch/arm/mach-at91/at91sam9g45_devices.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/arm/mach-at91/at91sam9g45_devices.c b/arch/arm/mach-at91/at91sam9g45_devices.c
> index eec5eb6..2134663 100644
> --- a/arch/arm/mach-at91/at91sam9g45_devices.c
> +++ b/arch/arm/mach-at91/at91sam9g45_devices.c
> @@ -686,18 +686,12 @@ void __init at91_add_device_i2c(short i2c_id, struct i2c_board_info *devices, in
> /* pins used for TWI interface */
> if (i2c_id == 0) {
> at91_set_A_periph(AT91_PIN_PA20, 0); /* TWD */
> - at91_set_multi_drive(AT91_PIN_PA20, 1);
> -
> at91_set_A_periph(AT91_PIN_PA21, 0); /* TWCK */
> - at91_set_multi_drive(AT91_PIN_PA21, 1);
>
> platform_device_register(&at91sam9g45_twi0_device);
> } else {
> at91_set_A_periph(AT91_PIN_PB10, 0); /* TWD */
> - at91_set_multi_drive(AT91_PIN_PB10, 1);
> -
> at91_set_A_periph(AT91_PIN_PB11, 0); /* TWCK */
> - at91_set_multi_drive(AT91_PIN_PB11, 1);
>
> platform_device_register(&at91sam9g45_twi1_device);
> }
>
next parent reply other threads:[~2012-08-27 10:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1345618760.git.n.voss@weinmann.de>
[not found] ` <6acdbd0f06cb9902efc510346564e10b07fa0b91.1345618760.git.n.voss@weinmann.de>
2012-08-27 10:24 ` ludovic.desroches [this message]
2012-08-27 13:22 ` [PATCH v11 4/4] G45 TWI: remove open drain setting for twi function gpios Voss, Nikolaus
2012-08-27 13:27 ` ludovic.desroches
[not found] ` <4f3dcfbf1e8eab3e251ab3558e9e1e9123643928.1345618760.git.n.voss@weinmann.de>
2012-08-27 10:16 ` [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver ludovic.desroches
2012-08-27 10:40 ` Yanes Martinez Adrian
2012-08-27 12:04 ` ludovic.desroches
2012-08-27 12:45 ` Yanes Martinez Adrian
2012-08-27 13:32 ` Voss, Nikolaus
2012-08-27 14:00 ` ludovic.desroches
2012-08-27 14:29 ` Voss, Nikolaus
2012-09-11 8:26 ` Nicolas Ferre
2012-09-11 22:13 ` Wolfram Sang
2012-08-30 7:35 ` ludovic.desroches
2012-08-28 15:10 ` ludovic.desroches
2012-08-28 15:32 ` Voss, Nikolaus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503B4AE6.4090107@atmel.com \
--to=ludovic.desroches@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox