From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: S3C24XX: Add .get_rate callback for "camif-upll" clock
Date: Mon, 27 Aug 2012 15:58:14 -0700 [thread overview]
Message-ID: <503BFB86.20607@samsung.com> (raw)
In-Reply-To: <1346098329-32059-1-git-send-email-sylvester.nawrocki@gmail.com>
On 08/27/12 13:12, Sylwester Nawrocki wrote:
> Add missing get_rate callback for the "camif-upll" clock, so frequency
> of this clock is properly reported with clk_get_rate().
>
> Signed-off-by: Sylwester Nawrocki<sylvester.nawrocki@gmail•com>
> ---
> arch/arm/mach-s3c24xx/clock-s3c2440.c | 14 ++++++++++++++
> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/clock-s3c2440.c b/arch/arm/mach-s3c24xx/clock-s3c2440.c
> index cb2883d..749220f 100644
> --- a/arch/arm/mach-s3c24xx/clock-s3c2440.c
> +++ b/arch/arm/mach-s3c24xx/clock-s3c2440.c
> @@ -87,6 +87,19 @@ static int s3c2440_camif_upll_setrate(struct clk *clk, unsigned long rate)
> return 0;
> }
>
> +static unsigned long s3c2440_camif_upll_getrate(struct clk *clk)
> +{
> + unsigned long parent_rate = clk_get_rate(clk->parent);
> + unsigned long camdivn = __raw_readl(S3C2440_CAMDIVN);
> +
> + if (!(camdivn& S3C2440_CAMDIVN_CAMCLK_SEL))
> + return parent_rate;
> +
> + camdivn&= S3C2440_CAMDIVN_CAMCLK_MASK;
> +
> + return parent_rate / (camdivn + 1) / 2;
Well, why do we need '/ 2' here?
> +}
> +
> /* Extra S3C2440 clocks */
>
> static struct clk s3c2440_clk_cam = {
> @@ -99,6 +112,7 @@ static struct clk s3c2440_clk_cam_upll = {
> .name = "camif-upll",
> .ops =&(struct clk_ops) {
> .set_rate = s3c2440_camif_upll_setrate,
> + .get_rate = s3c2440_camif_upll_getrate,
> .round_rate = s3c2440_camif_upll_round,
> },
> };
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung•com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-08-27 22:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 20:12 [PATCH] ARM: S3C24XX: Add .get_rate callback for "camif-upll" clock Sylwester Nawrocki
2012-08-27 22:58 ` Kukjin Kim [this message]
2012-08-28 20:58 ` Sylwester Nawrocki
2012-08-28 23:10 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503BFB86.20607@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox