From: kgene.kim@samsung•com (Kukjin Kim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 2/3] ARM: Exynos5: Add AUXDATA support for MSHC controllers
Date: Mon, 27 Aug 2012 16:11:32 -0700 [thread overview]
Message-ID: <503BFEA4.1070601@samsung.com> (raw)
In-Reply-To: <1345982371-26483-3-git-send-email-thomas.abraham@linaro.org>
On 08/26/12 04:59, Thomas Abraham wrote:
> Add entries if MSHC controllers in AUXDATA table for correct device name
> initialization.
>
> Signed-off-by: Abhilash Kesavan<a.kesavan@samsung•com>
> Signed-off-by: Thomas Abraham<thomas.abraham@linaro•org>
> ---
> arch/arm/mach-exynos/include/mach/map.h | 1 +
> arch/arm/mach-exynos/mach-exynos5-dt.c | 8 ++++++++
> 2 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h
> index 9d1f3ac..5b0ee41 100644
> --- a/arch/arm/mach-exynos/include/mach/map.h
> +++ b/arch/arm/mach-exynos/include/mach/map.h
> @@ -172,6 +172,7 @@
>
> #define EXYNOS4_PA_HSMMC(x) (0x12510000 + ((x) * 0x10000))
> #define EXYNOS4_PA_DWMCI 0x12550000
> +#define EXYNOS5_PA_DWMCI(x) (0x12200000 + ((x) * 0x10000))
Just, how about EXYNOS5_PA_DWMMC0, EXYNOS5_PA_DWMMC1, ... EXYNOS_PA_DWMMC3?
And if the addresses are different on other EXYNOS5 SoC, how do we
handle it for auxdata?
>
> #define EXYNOS4_PA_HSOTG 0x12480000
> #define EXYNOS4_PA_USB_HSPHY 0x125B0000
> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
> index ef770bc..4257cc1 100644
> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c
> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
> @@ -47,6 +47,14 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = {
> "s3c2440-i2c.0", NULL),
> OF_DEV_AUXDATA("samsung,s3c2440-i2c", EXYNOS5_PA_IIC(1),
> "s3c2440-i2c.1", NULL),
> + OF_DEV_AUXDATA("samsung,exynos5250-dw-mshc", EXYNOS5_PA_DWMCI(0),
As I commented, how about just 'samsung,dw-mmc'? but I'm not sure.
> + "dw_mmc.0", NULL),
> + OF_DEV_AUXDATA("samsung,exynos5250-dw-mshc", EXYNOS5_PA_DWMCI(1),
> + "dw_mmc.1", NULL),
> + OF_DEV_AUXDATA("samsung,exynos5250-dw-mshc", EXYNOS5_PA_DWMCI(2),
> + "dw_mmc.2", NULL),
> + OF_DEV_AUXDATA("samsung,exynos5250-dw-mshc", EXYNOS5_PA_DWMCI(3),
> + "dw_mmc.3", NULL),
> OF_DEV_AUXDATA("samsung,exynos4210-spi", EXYNOS5_PA_SPI0,
> "exynos4210-spi.0", NULL),
> OF_DEV_AUXDATA("samsung,exynos4210-spi", EXYNOS5_PA_SPI1,
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung•com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-08-27 23:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 11:59 [PATCH v3 0/3] ARM: Exynos5: Add support for MSHC controller Thomas Abraham
2012-08-26 11:59 ` [PATCH v3 1/3] ARM: Samsung: Add support for MSHC controller clocks Thomas Abraham
2012-08-27 23:15 ` Kukjin Kim
2012-08-28 4:59 ` Thomas Abraham
2012-08-26 11:59 ` [PATCH v3 2/3] ARM: Exynos5: Add AUXDATA support for MSHC controllers Thomas Abraham
2012-08-27 23:11 ` Kukjin Kim [this message]
2012-08-28 5:02 ` Thomas Abraham
2012-08-26 11:59 ` [PATCH v3 3/3] ARM: dts: Add nodes for dw_mmc controllers for Samsung Exynos5250 platforms Thomas Abraham
2012-08-27 22:46 ` Kukjin Kim
2012-08-28 5:06 ` Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503BFEA4.1070601@samsung.com \
--to=kgene.kim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox