From: nsekhar@ti•com (Sekhar Nori)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API
Date: Fri, 31 Aug 2012 21:32:18 +0530 [thread overview]
Message-ID: <5040E00A.3080600@ti.com> (raw)
In-Reply-To: <20120830144307.GA26737@beef>
Hi Matt,
On 8/30/2012 8:13 PM, Matt Porter wrote:
> On Thu, Aug 30, 2012 at 07:46:32PM +0530, Sekhar Nori wrote:
>> Hi Matt,
>>
>> On 8/23/2012 6:39 AM, Matt Porter wrote:
>>> Removes use of the DaVinci EDMA private DMA API and replaces
>>> it with use of the DMA engine API.
>>>
>>> Signed-off-by: Matt Porter <mporter@ti•com>
>>
>> I tried testing this patch on my OMAP-L138 EVM, but SPI fails to
>> initialize after applying the patch.
>>
>> root at arago:~# dmesg | grep -i spi
>> spi_davinci spi_davinci.1: request RX DMA channel failed
>
> Hi Sekhar,
>
> Most likely CONFIG_TI_EDMA is off as it defaults to off in the v3
> series. Try enabling this and if it's the problem then this error
> path can be fixed to properly fallback to PIO only or fail to
> initialize as needed.
Yes, this was the problem. Since the SPI driver now depends on
CONFIG_TI_EDMA for basic operation may be select CONFIG_TI_EDMA in
Kconfig if SPI is enabled? That should do until the fallback to PIO is
implemented.
With that fixed, I tested SPI on OMAP-L138 EVM and it works great.
Tested a JFFS2 mount as well as some raw chardev read/write tests.
Tested-by: Sekhar Nori <nsekhar@ti•com>
Thanks,
Sekhar
next prev parent reply other threads:[~2012-08-31 16:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 1:09 [PATCH v3 0/3] DaVinci DMA engine conversion Matt Porter
2012-08-23 1:09 ` [PATCH v3 1/3] dmaengine: add TI EDMA DMA engine driver Matt Porter
2012-08-23 1:09 ` [PATCH v3 2/3] mmc: davinci_mmc: convert to DMA engine API Matt Porter
2012-08-23 1:09 ` [PATCH v3 3/3] spi: spi-davinci: " Matt Porter
2012-08-30 14:16 ` Sekhar Nori
2012-08-30 14:43 ` Matt Porter
2012-08-31 0:55 ` Vinod Koul
2012-08-31 16:02 ` Sekhar Nori [this message]
2012-08-31 16:31 ` Vinod Koul
2012-08-31 16:31 ` Sekhar Nori
2012-08-31 17:02 ` Vinod Koul
2012-09-01 1:02 ` Vinod Koul
2012-09-01 13:14 ` Matt Porter
2012-08-23 6:01 ` [PATCH v3 0/3] DaVinci DMA engine conversion Tom Rini
2012-08-27 15:33 ` Daniel Mack
2012-09-06 13:25 ` Daniel Mack
2012-09-10 20:20 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5040E00A.3080600@ti.com \
--to=nsekhar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox