From: peter.ujfalusi@ti•com (Peter Ujfalusi)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/8] ARM/dts: omap2: Add McBSP entries for OMAP2420 and OMAP2430 SoC
Date: Mon, 10 Sep 2012 14:05:25 +0300 [thread overview]
Message-ID: <504DC975.5070609@ti.com> (raw)
In-Reply-To: <504D9FBC.9030609@ti.com>
Hi Benoit,
On 09/10/2012 11:07 AM, Benoit Cousson wrote:
> Hi Tony,
>
> On 09/08/2012 12:29 AM, Tony Lindgren wrote:
>> * Peter Ujfalusi <peter.ujfalusi@ti•com> [120905 04:59]:
>>> +
>>> + ocp {
>>> + mcbsp1: mcbsp at 48074000 {
>>> + compatible = "ti,omap2420-mcbsp";
>>> + reg = <0x48074000 0xff>;
>>> + reg-names = "mpu";
>>> + interrupts = <59>, /* TX interrupt */
>>> + <60>; /* RX interrupt */
>>> + interrupt-names = "tx", "rx";
>>> + interrupt-parent = <&intc>;
>>> + ti,hwmods = "mcbsp1";
>>> + };
>>> +
>>> + mcbsp2: mcbsp at 48076000 {
>>> + compatible = "ti,omap2420-mcbsp";
>>> + reg = <0x48076000 0xff>;
>>> + reg-names = "mpu";
>>> + interrupts = <62>, /* TX interrupt */
>>> + <63>; /* RX interrupt */
>>> + interrupt-names = "tx", "rx";
>>> + interrupt-parent = <&intc>;
>>> + ti,hwmods = "mcbsp2";
>>> + };
>>> + };
>>
>> Hmm don't you need to specify the interrupt chip and offset for
>> the interrupts here?
>
> Mmm, I'm not sure to get your question, there is the link to the
> interrupt-parent.
>
> The interrupt number is relative to the parent interrupt domain. So even
> if the INTC IRQ offset start at 32 instead of 0, DT IRQ mechanism will
> convert that to the proper hwirq thanks to irqdomain.
> In that case we should always provide interrupt number relative to the
> interrupt controller HW number and not assuming any Linux IRQ number
> offset like before.
>
>
> And in fact the interrupt-parent is not even needed, by default if will
> look to the parent to get the interrupt-controller.
This is true, but it makes the 'code' a bit more readable if I (we) specify
the interrupt-parent.
>
> Extract from [1]
>
> interrupt-parent:
> "Because the hierarchy of the nodes in the interrupt tree might not
> match the device tree, the interrupt-parent property is available to
> make the definition of an interrupt parent explicit.
> The value is the phandle to the interrupt parent. If this property is
> missing from a device, its interrupt parent is assumed to be its device
> tree parent."
>
> [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
>
> Regards,
> Benoit
>
--
P?ter
next prev parent reply other threads:[~2012-09-10 11:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 11:58 [PATCH v3 0/8] ARM/dts: OMAP audio related updates for OMAP2/3/4/5 Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 1/8] ARM/dts: omap2: Add McBSP entries for OMAP2420 and OMAP2430 SoC Peter Ujfalusi
2012-09-07 22:29 ` Tony Lindgren
2012-09-10 8:07 ` Benoit Cousson
2012-09-10 11:05 ` Peter Ujfalusi [this message]
2012-09-10 16:01 ` Tony Lindgren
2012-09-05 11:58 ` [PATCH v3 2/8] ARM/dts: omap2420-h4: Include omap2420.dtsi file instead the common omap2 Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 3/8] ARM/dts: omap3: Add McBSP entries Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 4/8] ARM/dts: omap4: " Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 5/8] ARM/dts: omap4: Add reg-names for McPDM and DMIC Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 6/8] ARM/dts: omap5: Add McBSP entries Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 7/8] ARM/dts: omap5: Add McPDM and DMIC section to the dtsi file Peter Ujfalusi
2012-09-05 11:58 ` [PATCH v3 8/8] ARM/dts: omap3-beagle: Enable audio support Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504DC975.5070609@ti.com \
--to=peter.ujfalusi@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox