public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: b-cousson@ti•com (Benoit Cousson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo
Date: Mon, 10 Sep 2012 15:25:34 +0200	[thread overview]
Message-ID: <504DEA4E.7080109@ti.com> (raw)
In-Reply-To: <1347282996-31190-2-git-send-email-florian.vaussard@epfl.ch>

On 09/10/2012 03:16 PM, Florian Vaussard wrote:
> Support the blue LED connected to the LEDB pin of the TWL4030
> on the Gumstix Overo.
> 
> Signed-off-by: Florian Vaussard <florian.vaussard@epfl•ch>
> ---
>  arch/arm/boot/dts/omap3-overo.dtsi |   15 +++++++++++++++
>  1 files changed, 15 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/omap3-overo.dtsi b/arch/arm/boot/dts/omap3-overo.dtsi
> index d6cc5e2..89808ce 100644
> --- a/arch/arm/boot/dts/omap3-overo.dtsi
> +++ b/arch/arm/boot/dts/omap3-overo.dtsi
> @@ -13,6 +13,17 @@
>  
>  /include/ "omap3.dtsi"
>  
> +/ {

BTW, I'm just wondering. Cannot we use overo without tobi?

In that case, the model and compatible should probably be used as well:

	model = "TI OMAP3 Gumstix Overo";
	compatible = "ti,omap3-overo", "ti,omap3";


> +	leds {
> +		compatible = "gpio-leds";
> +		overo {
> +			label = "overo:blue:COM";
> +			gpios = <&twl_gpio 19 0>;
> +			linux,default-trigger = "mmc0";
> +		};
> +	};
> +};
> +
>  &i2c1 {
>  	clock-frequency = <2600000>;
>  
> @@ -40,3 +51,7 @@
>  &mmc2 {
>  	bus-width = <4>;
>  };
> +
> +&twl_gpio {
> +	ti,use-leds;
> +};
> 

Otherwise, it is fine.

Thanks,
Benoit

  reply	other threads:[~2012-09-10 13:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 13:16 [PATCH 0/1] ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo Florian Vaussard
2012-09-10 13:16 ` [PATCH 1/1] " Florian Vaussard
2012-09-10 13:25   ` Benoit Cousson [this message]
2012-09-10 13:33     ` Florian Vaussard
2012-09-10 13:40       ` Benoit Cousson
2012-09-10 13:49         ` Benoit Cousson
2012-09-10 14:07         ` Florian Vaussard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504DEA4E.7080109@ti.com \
    --to=b-cousson@ti$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox