From: juhosg@openwrt•org (Gabor Juhos)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] gpio: 74x164: Add support for the daisy-chaining
Date: Tue, 11 Sep 2012 21:35:45 +0200 [thread overview]
Message-ID: <504F9291.9060609@openwrt.org> (raw)
In-Reply-To: <CACRpkdbo1sj6gbucoF3WVLbHzFXtddZiUQ-=h9gn-+A4Z7qBnQ@mail.gmail.com>
2012.09.11. 19:05 keltez?ssel, Linus Walleij ?rta:
> On Mon, Sep 10, 2012 at 10:35 PM, Maxime Ripard
> <maxime.ripard@free-electrons•com> wrote:
>
>> The shift registers have an output pin that, when enabled, propagates
>> the values of its internal register to the pins. If another value comes
>> to the register while the output pin is disabled, this new value will
>> makae the older shift into the next register in the chain.
>>
>> This patch adds support for daisy-chaining the registers, using the
>> regular SPI chip select mechanism to manage the output pin, and the
>> registers-number dt property to set the number of chained registers.
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons•com>
>
> OK cool, but I just realized that this driver was added just two
> years ago by Gabor and Miguel, so I'd like to get their feedback
> before continuing.
>
> I know I already merged the DT support and stuff, but better
> late than never.
>
> Please include them on future postings of patches to this
> driver... (See To: line)
>
> Miguel, Gabor: please look at this, I hope you can get hold
> of the patches. Please also check the stuff I've already merged
> here:
> http://git.kernel.org/?p=linux/kernel/git/linusw/linux-gpio.git;a=shortlog;h=refs/heads/devel
The merged patches look good in general. The merged patches look good in
general. However I don't know anything about the 74x164 chip. The driver contain
my copyright only because it was based on another driver which I wrote for a
different chip.
-Gabor
next prev parent reply other threads:[~2012-09-11 19:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 20:35 [PATCHv3 0/3] gpios: Add daisy-chaining and dt support to 74x164 Maxime Ripard
2012-09-10 20:35 ` [PATCH 1/3] gpio: 74x164: Add support for the daisy-chaining Maxime Ripard
2012-09-11 17:05 ` Linus Walleij
2012-09-11 19:35 ` Gabor Juhos [this message]
2012-09-11 21:51 ` Linus Walleij
2012-09-12 7:23 ` Miguel GAIO
2012-09-10 20:35 ` [PATCH 2/3] gpio: 74x164: dts: Add documentation for the dt binding Maxime Ripard
2012-09-11 17:22 ` Linus Walleij
2012-09-11 21:52 ` Linus Walleij
2012-09-12 11:51 ` Maxime Ripard
2012-09-10 20:35 ` [PATCH 3/3] ARM: dts: cfa10049: Add the 74HC595 gpio expanders Maxime Ripard
2012-09-12 2:30 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504F9291.9060609@openwrt.org \
--to=juhosg@openwrt$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox