From: ludovic.desroches@atmel•com (ludovic.desroches)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 0/8] i2c: at91: cleanup and dt support
Date: Wed, 12 Sep 2012 13:12:23 +0200 [thread overview]
Message-ID: <50506E17.1080904@atmel.com> (raw)
In-Reply-To: <20120912101607.GA2624@pengutronix.de>
Hi Wolfram,
Le 09/12/2012 12:16 PM, Wolfram Sang a ?crit :
> On Wed, Sep 12, 2012 at 10:03:59AM +0200, Nicolas Ferre wrote:
>> On 09/12/2012 08:42 AM, ludovic.desroches at atmel.com :
>>> From: Ludovic Desroches <ludovic.desroches@atmel•com>
>>>
>>> Hi,
>>>
>>> This set of patches is based on Nikolaus at91_i2c driver.
>>>
>>> Changes:
>>> v3:
>>> - only put multi-drive lines in the if...else statement (suggested
>>> by Warner Losh)
>>
>> Hi Wolfram,
>>
>> As said by Ludovic, this series goes on top of Nikolaus' one.
>> My Acked-by is already set on this one, so I think that I have nothing
>> more to do ;-)
>>
>> BTW, in case you need help to sort all this, do not hesitate to contact
>> us... we can setup a git tree for this...
>
> I think I am fine. Patches look good. I wondered a bit about first
> removing the old driver, then adding the new one with regard to
> bisectability. But as the old driver depends on BROKEN, I think this is
> OK to do.
>
> One thing I'd like to make, though. I'd like to squash the following
> patches into one:
>
> drivers/i2c/busses/i2c-at91.c: add new driver
> i2c: at91: use managed resources
> i2c: at91: add warning about transmission issues for some devices
> i2c: at91: use an id table for SoC dependent parameters
>
> It is especially the last patch I am mostly interested in. The id_table
> approach is what I like, while the original id_entry mechanism looks
> fishy. I'd was good for reviewing to have the patches split like this;
> yet for hitting mainline, I'd prefer to have the driver proper on first
> occasion. I already did the squashing in a test-branch and the result
> looks good to me.
>
> Nikolaus, Ludovic: Are you fine with this?
>
No problem on my side.
Regards
Ludovic
> Thanks,
>
> Wolfram
>
next prev parent reply other threads:[~2012-09-12 11:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 6:42 [PATCH v3 0/8] i2c: at91: cleanup and dt support ludovic.desroches at atmel.com
2012-09-12 6:42 ` [PATCH v3 1/8] i2c: at91: use managed resources ludovic.desroches at atmel.com
2012-09-12 6:42 ` [PATCH v3 2/8] i2c: at91: add warning about transmission issues for some devices ludovic.desroches at atmel.com
2012-09-12 6:42 ` [PATCH v3 3/8] i2c: at91: use an id table for SoC dependent parameters ludovic.desroches at atmel.com
2012-09-12 6:42 ` [PATCH v3 4/8] ARM: at91: do not configure at91sam9g10 twi pio as open-drain ludovic.desroches at atmel.com
2012-09-12 6:42 ` [PATCH v3 5/8] i2c: at91: add dt support to i2c-at91 ludovic.desroches at atmel.com
2012-09-12 6:42 ` [PATCH v3 6/8] ARM: at91: add clocks for I2C DT entries ludovic.desroches at atmel.com
2012-09-12 6:42 ` [PATCH v3 7/8] ARM: dts: add twi nodes for atmel SoCs ludovic.desroches at atmel.com
2012-09-12 6:42 ` [PATCH v3 8/8] ARM: dts: add twi nodes for atmel boards ludovic.desroches at atmel.com
2012-09-12 8:03 ` [PATCH v3 0/8] i2c: at91: cleanup and dt support Nicolas Ferre
2012-09-12 10:16 ` Wolfram Sang
2012-09-12 10:39 ` Voss, Nikolaus
2012-09-12 11:12 ` ludovic.desroches [this message]
2012-09-12 12:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50506E17.1080904@atmel.com \
--to=ludovic.desroches@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox