From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] media: add V4L2 DT binding documentation
Date: Wed, 12 Sep 2012 12:53:52 -0600 [thread overview]
Message-ID: <5050DA40.8050105@wwwdotorg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1209111746420.22084@axis700.grange>
On 09/11/2012 09:51 AM, Guennadi Liakhovetski wrote:
> This patch adds a document, describing common V4L2 device tree bindings.
>
> Co-authored-by: Sylwester Nawrocki <s.nawrocki@samsung•com>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx•de>
Overall, I think this looks pretty reasonable, so:
Acked-by: Stephen Warren <swarren@wwwdotorg•org>
Just a couple comments:
> +++ b/Documentation/devicetree/bindings/media/v4l2.txt
> + ceu0: ceu at 0xfe910000 {
> + mclk: master_clock {
> + compatible = "renesas,ceu-clock";
> + #clock-cells = <1>;
Why 1? If there's only 1 clock output from this provider, I don't see a
need for any cells, unless there are some configuration flags?
> + clock-frequency = <50000000>; /* max clock frequency */
> + clock-output-names = "mclk";
> + };
> +
> + port {
...
> + ceu0_0: link at 0 {
> + reg = <0>;
> + remote = <&csi2_2>;
> + immutable;
Did we decide "immutable" was actually needed? Presumably the driver for
the HW in question knows the HW isn't configurable, and would simply not
attempt to apply any configuration even if the .dts author erroneously
provided some?
> + };
> + };
> + };
> +
> + i2c0: i2c at 0xfff20000 {
...
> + ov772x_1: camera at 0x21 {
...
> + clocks = <&mclk 0>;
So presumably that could just be "clocks = <&mclk>;"?
next prev parent reply other threads:[~2012-09-12 18:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 15:51 [PATCH] media: add V4L2 DT binding documentation Guennadi Liakhovetski
2012-09-11 17:04 ` Sylwester Nawrocki
2012-09-25 14:59 ` Guennadi Liakhovetski
2012-09-12 18:53 ` Stephen Warren [this message]
2012-09-12 19:28 ` Guennadi Liakhovetski
2012-09-12 20:53 ` Stephen Warren
2012-09-12 21:17 ` Guennadi Liakhovetski
2012-09-12 22:59 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5050DA40.8050105@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox