From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] i2c: i2c-gpio: fix issue when DT node greater than 1
Date: Tue, 18 Sep 2012 08:51:59 -0600 [thread overview]
Message-ID: <50588A8F.30203@wwwdotorg.org> (raw)
In-Reply-To: <1347958949-5598-1-git-send-email-voice.shen@atmel.com>
On 09/18/2012 03:02 AM, Bo Shen wrote:
> When i2c-gpio node number is greater than 1, the second can not sucessfully
> regiter
>
> Using alias method to get the pdev->id, or else the second device will use
> the same id which will cause fail to register
pdev->id shouldn't be used at all with device tree. Why does
registration fail without this change?
> diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
> index e62d2d9..051fbb3 100644
> --- a/drivers/i2c/busses/i2c-gpio.c
> +++ b/drivers/i2c/busses/i2c-gpio.c
> @@ -136,6 +136,7 @@ static int __devinit i2c_gpio_probe(struct platform_device *pdev)
> ret = of_i2c_gpio_probe(pdev->dev.of_node, pdata);
> if (ret)
> return ret;
> + pdev->id = of_alias_get_id(pdev->dev.of_node, "i2c-gpio");
> } else {
> if (!pdev->dev.platform_data)
> return -ENXIO;
>
next prev parent reply other threads:[~2012-09-18 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 9:02 [PATCH] i2c: i2c-gpio: fix issue when DT node greater than 1 Bo Shen
2012-09-18 14:51 ` Stephen Warren [this message]
2012-09-19 1:15 ` Bo Shen
2012-09-19 15:28 ` Stephen Warren
2012-09-19 15:54 ` Jean Delvare
2012-10-10 2:54 ` Bo Shen
2012-10-15 2:59 ` Bo Shen
2012-10-15 5:55 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-15 6:49 ` Jean Delvare
2012-10-15 7:32 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50588A8F.30203@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox