From: jason.wessel@windriver•com (Jason Wessel)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 07/11] tty/serial: Add kgdb_nmi driver
Date: Thu, 20 Sep 2012 08:57:26 -0500 [thread overview]
Message-ID: <505B20C6.5090308@windriver.com> (raw)
In-Reply-To: <1348098122-11041-7-git-send-email-anton.vorontsov@linaro.org>
On 09/19/2012 06:41 PM, Anton Vorontsov wrote:
> This special driver makes it possible to temporary use NMI debugger port
> as a normal console by issuing 'nmi_console' command (assuming that the
> port is attached to KGDB).
>
The kgdb regression compiler also does checkpatch, so the "check patch
police" don't come chasing us let's get rid of this warning. This
comes with the disclaimer that I believe checkpatch is a bit overly
agressive in the first place. :-)
WARNING: quoted string split across lines
#133: FILE: drivers/tty/serial/kgdb_nmi.c:36:
+MODULE_PARM_DESC(knock, "if set to 1 (default), the special '$3#33' command "
+ "must be used to enter the debugger; when set to 0, "
---
drivers/tty/serial/kgdb_nmi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/drivers/tty/serial/kgdb_nmi.c
+++ b/drivers/tty/serial/kgdb_nmi.c
@@ -32,10 +32,10 @@
static int kgdb_nmi_knock = 1;
module_param_named(knock, kgdb_nmi_knock, int, 0600);
-MODULE_PARM_DESC(knock, "if set to 1 (default), the special '$3#33' command "
- "must be used to enter the debugger; when set to 0, "
- "hitting return key is enough to enter the debugger; "
- "when set to -1, the debugger is entered immediately "
+MODULE_PARM_DESC(knock, "if set to 1 (default), the special '$3#33' command " \
+ "must be used to enter the debugger; when set to 0, " \
+ "hitting return key is enough to enter the debugger; " \
+ "when set to -1, the debugger is entered immediately " \
"upon NMI");
static char *kgdb_nmi_magic = "$3#33";
next prev parent reply other threads:[~2012-09-20 13:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 23:40 [PATCH v8 0/11] KGDB/KDB FIQ (NMI) debugger Anton Vorontsov
2012-09-19 23:41 ` [PATCH 01/11] kernel/debug: Mask KGDB NMI upon entry Anton Vorontsov
2012-09-19 23:41 ` [PATCH 02/11] kdb: Implement disable_nmi command Anton Vorontsov
2012-09-19 23:41 ` [PATCH 03/11] kdb: Turn KGDB_KDB=n stubs into static inlines Anton Vorontsov
2012-09-19 23:41 ` [PATCH 04/11] tty/serial/core: Introduce poll_init callback Anton Vorontsov
2012-09-19 23:41 ` [PATCH 05/11] tty/serial/amba-pl011: Implement " Anton Vorontsov
2012-09-19 23:41 ` [PATCH 06/11] tty/serial/amba-pl011: Quiesce interrupts in poll_get_char Anton Vorontsov
2012-09-19 23:41 ` [PATCH 07/11] tty/serial: Add kgdb_nmi driver Anton Vorontsov
2012-09-20 13:57 ` Jason Wessel [this message]
2012-09-20 18:30 ` [PATCH updated " Anton Vorontsov
2012-09-19 23:41 ` [PATCH 08/11] ARM: Move some macros from entry-armv to entry-header Anton Vorontsov
2012-09-19 23:42 ` [PATCH 09/11] ARM: Add KGDB/KDB FIQ debugger generic code Anton Vorontsov
2012-09-19 23:42 ` [PATCH 10/11] ARM: VIC: Add a couple of low-level FIQ management helpers Anton Vorontsov
2012-09-19 23:42 ` [PATCH 11/11] ARM: versatile: Make able to use UART ports for KGDB FIQ debugger Anton Vorontsov
2012-09-20 13:40 ` [PATCH v8 0/11] KGDB/KDB FIQ (NMI) debugger Jason Wessel
2012-09-24 10:46 ` Jason Wessel
2012-09-24 21:25 ` Anton Vorontsov
-- strict thread matches above, loose matches on Subject: below --
2012-09-24 21:26 [PATCH v9 " Anton Vorontsov
2012-09-24 21:27 ` [PATCH 07/11] tty/serial: Add kgdb_nmi driver Anton Vorontsov
2012-09-13 15:01 [PATCH v7 0/11] KGDB/KDB FIQ (NMI) debugger Anton Vorontsov
2012-09-13 15:03 ` [PATCH 07/11] tty/serial: Add kgdb_nmi driver Anton Vorontsov
2012-09-15 15:52 ` Francesco Lavra
2012-09-19 11:52 ` Jason Wessel
2012-09-19 16:54 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505B20C6.5090308@windriver.com \
--to=jason.wessel@windriver$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox