From: maxime.ripard@free-electrons•com (Maxime Ripard)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: mxs: m28evk: Disable OCOTP OUI loading
Date: Thu, 20 Sep 2012 19:01:20 +0200 [thread overview]
Message-ID: <505B4BE0.2030702@free-electrons.com> (raw)
In-Reply-To: <201209201833.38960.marex@denx.de>
Le 20/09/2012 18:33, Marek Vasut a ?crit :
> Dear Maxime Ripard,
>
>> Hi Marek,
>>
>> Le 20/09/2012 15:10, Marek Vasut a ?crit :
>>>>> If barebox can't handle even basic DT fixup, it's broken.
>>>>
>>>> It can. It maybe was just not needed up to now, dunno.
>>>
>>> Fix it and send patch, so this problem doesn't spread.
>>
>> I'm sorry, but you still miss the point.
>>
>> If someone wants to use another bootloader than U-boot (or a possible
>> patched barebox), or none other than the bootlets to boot directly the
>> Linux (with an appended device tree), you will still have no way to get
>> the NIC from the OCOTP, and I'm sorry, but it is just wrong.
>>
>> The kernel shouldn't rely on a particular feature of a given bootloader.
>
> So what do you think about this patch (skip loading from OCOTP if it's already
> present in DT):
>
> diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c
> index 71d47f5..4f014ef 100644
> --- a/arch/arm/mach-mxs/mach-mxs.c
> +++ b/arch/arm/mach-mxs/mach-mxs.c
> @@ -175,6 +175,10 @@ static void __init update_fec_mac_prop(enum mac_oui oui)
> np = of_find_compatible_node(from, NULL, "fsl,imx28-fec");
> if (!np)
> return;
> +
> + if (of_get_property(np, "local-mac-address", NULL))
> + continue;
> +
> from = np;
>
> newmac = kzalloc(sizeof(*newmac) + 6, GFP_KERNEL);
That definitely looks like the best solution, yes.
You can add my Acked-by if you want.
Maxime
--
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-09-20 17:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 22:37 [PATCH] ARM: mxs: m28evk: Disable OCOTP OUI loading Marek Vasut
2012-09-19 3:15 ` Shawn Guo
2012-09-19 9:43 ` Marek Vasut
2012-09-19 10:33 ` Maxime Ripard
2012-09-19 10:50 ` Marek Vasut
2012-09-19 11:02 ` Maxime Ripard
2012-09-19 11:25 ` Marek Vasut
2012-09-19 11:44 ` Maxime Ripard
2012-09-19 11:51 ` Marek Vasut
2012-09-20 10:47 ` Wolfram Sang
2012-09-20 12:20 ` Marek Vasut
2012-09-20 12:56 ` Wolfram Sang
2012-09-20 13:10 ` Marek Vasut
2012-09-20 13:53 ` Maxime Ripard
2012-09-20 14:24 ` Marek Vasut
2012-09-20 15:10 ` Wolfgang Denk
2012-09-20 15:24 ` Gregory CLEMENT
2012-09-20 15:31 ` Marek Vasut
2012-09-20 17:09 ` Wolfgang Denk
2012-09-20 16:33 ` Marek Vasut
2012-09-20 17:01 ` Maxime Ripard [this message]
2012-09-20 17:31 ` Marek Vasut
2012-09-19 14:17 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505B4BE0.2030702@free-electrons.com \
--to=maxime.ripard@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox