From: jh80.chung@samsung•com (Jaehoon Chung)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] mmc: sdhci: rename platform_8bit_width to platform_bus_width
Date: Tue, 25 Sep 2012 16:28:17 +0900 [thread overview]
Message-ID: <50615D11.8000503@samsung.com> (raw)
In-Reply-To: <20120925061504.GV1322@pengutronix.de>
On 09/25/2012 03:15 PM, Sascha Hauer wrote:
> On Tue, Sep 25, 2012 at 11:35:14AM +0900, Jaehoon Chung wrote:
>> On 09/24/2012 04:22 PM, Sascha Hauer wrote:
>>> /*
>>> * If your platform has 8-bit width support but is not a v3 controller,
>>> * or if it requires special setup code, you should implement that in
>>> - * platform_8bit_width().
>>> + * platform_bus_width().
>>> */
>>> - if (host->ops->platform_8bit_width)
>>> - host->ops->platform_8bit_width(host, ios->bus_width);
>>> - else {
>>> + if (host->ops->platform_bus_width) {
>>> + host->ops->platform_bus_width(host, ios->bus_width);
>>> + } else {
>> Why add the brackets?
>
> Took the chance to cleanup the codingstyle when changing these lines
> anyway.
Anyway, this patch is reasonable. Looks good to me.
Best Regards,
Jaehoon Chung
>
> Sascha
>
>
next prev parent reply other threads:[~2012-09-25 7:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 7:22 [PATCH] mmc: sdhci / i.MX esdhc buswidth patches Sascha Hauer
2012-09-24 7:22 ` [PATCH 1/3] mmc: sdhci: rename platform_8bit_width to platform_bus_width Sascha Hauer
2012-09-25 2:35 ` Jaehoon Chung
2012-09-25 6:15 ` Sascha Hauer
2012-09-25 7:28 ` Jaehoon Chung [this message]
2012-09-24 7:22 ` [PATCH 2/3] mmc: esdhc i.MX: Fix version register read Sascha Hauer
2012-09-25 6:41 ` Shawn Guo
2012-12-25 13:00 ` Shawn Guo
2012-09-24 7:22 ` [PATCH 3/3] mmc: esdhc i.MX: Support 8bit mode Sascha Hauer
2012-09-25 7:15 ` Shawn Guo
2012-09-25 7:27 ` Sascha Hauer
2012-09-25 7:33 ` Shawn Guo
2012-09-25 7:38 ` Sascha Hauer
2012-09-25 7:45 ` Shawn Guo
2012-09-25 8:05 ` Sascha Hauer
2012-09-25 8:50 ` Shawn Guo
2012-09-25 9:45 ` Sascha Hauer
2012-09-25 7:52 ` Chris Ball
2012-09-25 7:53 ` Shawn Guo
2012-09-25 8:00 ` Chris Ball
2012-12-26 2:56 ` Shawn Guo
2012-09-25 6:44 ` [PATCH] mmc: sdhci / i.MX esdhc buswidth patches Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50615D11.8000503@samsung.com \
--to=jh80.chung@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox