From: yegor_sub1@visionsystems•de (Yegor Yefremov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX
Date: Tue, 25 Sep 2012 10:28:17 +0200 [thread overview]
Message-ID: <50616B21.3070909@visionsystems.de> (raw)
In-Reply-To: <20120925081449.GF31374@n2100.arm.linux.org.uk>
On 25.09.2012 10:14, Russell King - ARM Linux wrote:
> On Tue, Sep 25, 2012 at 10:05:30AM +0200, Yegor Yefremov wrote:
>> How should I change the patch to make it proper? SA1111 is broken anyway:
> No it isn't. This is what it produces _today_, and has done for the last
> 5-10 years without modification
>
> # CONFIG_CLEANCACHE is not set
> # CONFIG_FRONTSWAP is not set
> CONFIG_FORCE_MAX_ZONEORDER=9
> CONFIG_LEDS=y
> CONFIG_LEDS_CPU=y
>
>> config FORCE_MAX_ZONEORDER
>> int "Maximum zone order" if ARCH_SHMOBILE
>> range 11 64 if ARCH_SHMOBILE
>> default "9" if SA1111
>> default "11"
>>
>> AFAIK if ARCH_SHMOBILE defines dependency on ARCH_SHMOBILE,
> No it doens't.
>
> int "Maximum zone order" if ARCH_SHMOBILE
>
> is far from being the same as:
>
> int "Maximum zone order"
> depends on ARCH_SHMOBILE
>
> The former defines a condition upon which the option is offered in GUIs -
> or to put it another way, it defines the visibility of the option.
>
> The latter defines a dependency which must be met for the option to be
> both visible and appear in the resulting configuration file.
>
>> so SA1111 won't be evaluated (at least if I select SA1111
> And did you check that SA1111 remains selected? I bet you didn't. Or
> maybe you tested your patched version. Whatever. The original works,
> and has been known to work for years. Your patch breaks it. It's
> really as simple as that.
Thanks for explanation. I think I've got it now. Please review the v2 version.
Yegor
next prev parent reply other threads:[~2012-09-25 8:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 14:20 [PATCH] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX yegorslists at googlemail.com
2012-09-24 17:18 ` Tony Lindgren
2012-09-24 19:05 ` Yegor Yefremov
2012-09-24 23:16 ` Russell King - ARM Linux
2012-09-25 0:37 ` Tony Lindgren
2012-09-25 8:05 ` Yegor Yefremov
2012-09-25 8:14 ` Russell King - ARM Linux
2012-09-25 8:28 ` Yegor Yefremov [this message]
2012-09-27 14:12 ` Dejan Gačnik
2012-10-08 20:55 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50616B21.3070909@visionsystems.de \
--to=yegor_sub1@visionsystems$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox