From: mmayer@broadcom•com (Markus Mayer)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/1] Fix segfault in DTC
Date: Tue, 25 Sep 2012 16:51:47 -0700 [thread overview]
Message-ID: <50624393.30607@broadcom.com> (raw)
In-Reply-To: <20120925233054.GL9800@truffula.fritz.box>
On 25/09/2012 16:30, David Gibson wrote:
> On Tue, Sep 25, 2012 at 10:58:09AM -0700, Markus Mayer wrote:
>> Prior to this change, an empty input file would cause a segfault, because
>> yylloc had never been initialized. There was never any characters for the
>> lexer to match, so YY_USER_ACTION was never executed before the parse error
>> was detected.
>>
>> When the parser printed the error message, it tried to include the name of
>> the file, but the structure holding the file name (yylloc.file, referenced
>> as pos->file) had never been initialized.
>>
>> Without the fix:
>>
>> $ ./dtc /dev/null
>> DTC: dts->dts on file "/dev/null"
>> Segmentation fault (core dumped)
>>
>> $ gdb dtc core
>> Program terminated with signal 11, Segmentation fault.
>> at scripts/dtc/srcpos.c:194
>> 194 fname = pos->file->name;
>> (gdb) bt
>> at scripts/dtc/srcpos.c:194
>> fmt=0x40d769 "%s", va=0x7fffbf027148) at scripts/dtc/srcpos.c:220
>> at scripts/dtc/dtc-parser.tab.c:1920
>> at scripts/dtc/treesource.c:38
>> at scripts/dtc/dtc.c:203
>> (gdb) p *pos
>> $1 = {first_line = 0, first_column = 0, last_line = 0, last_column = 0,
>> file = 0x0}
>
> Which dtc version did you observe this with? I'm unable to reproduce
> the SEGV with current git.
That was
$ cat version_gen.h
#define DTC_VERSION "DTC 1.2.0-g37c0b6a0"
from git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git.
In other words, the DTC used by the Linux 3.6-rc series.
Regards,
-Markus
next prev parent reply other threads:[~2012-09-25 23:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 22:48 [PATCH 0/1] Fix segfault in DTC Markus Mayer
2012-09-24 22:48 ` [PATCH 1/1] " Markus Mayer
2012-09-25 11:07 ` [PATCH 0/1] " Will Deacon
2012-09-25 15:44 ` Stephen Warren
2012-09-25 16:42 ` Markus Mayer
2012-09-25 17:58 ` Markus Mayer
2012-09-25 17:58 ` [PATCH 1/1] " Markus Mayer
2012-09-25 23:30 ` David Gibson
2012-09-25 23:51 ` Markus Mayer [this message]
2012-09-26 0:35 ` David Gibson
2012-09-26 16:38 ` Markus Mayer
2012-09-28 17:09 ` Stephen Warren
2012-09-28 18:53 ` Jon Loeliger
2012-09-28 19:05 ` Stephen Warren
2012-09-28 20:32 ` Jon Loeliger
2012-09-29 23:53 ` David Gibson
2012-10-01 5:34 ` Stephen Warren
2012-10-01 6:46 ` David Gibson
2012-10-01 16:41 ` Stephen Warren
2012-10-02 0:08 ` David Gibson
2012-10-03 21:33 ` Stephen Warren
2012-10-04 4:49 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50624393.30607@broadcom.com \
--to=mmayer@broadcom$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox