From: santosh.shilimkar@ti•com (Santosh Shilimkar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: Push selects for TWD/SCU into machine entries
Date: Thu, 4 Oct 2012 14:41:46 +0530 [thread overview]
Message-ID: <506D52D2.9060105@ti.com> (raw)
In-Reply-To: <1349340644-13937-1-git-send-email-sboyd@codeaurora.org>
On Thursday 04 October 2012 02:20 PM, Stephen Boyd wrote:
> The TWD and SCU configs are selected by default as long as
> SCORPIONMP is false and/or MCT is false. Implementing the logic
> this way certainly saves lines in the Kconfig but it precludes
> those machines which select SCORPIONMP or MCT from participating
> in the single zImage effort because when those machines are
> combined with other SMP capable machines the TWD and SCU are no
> longer selected.
>
> Push the select out to the machine entries so that we can compile
> these machines together and still select the appropriate configs.
>
> Signed-off-by: Stephen Boyd<sboyd@codeaurora•org>
> Cc: David Brown<davidb@codeaurora•org>
> Cc: Kukjin Kim<kgene.kim@samsung•com>
> Cc: Linus Walleij<linus.walleij@linaro•org>
> Cc: Pawel Moll<pawel.moll@arm•com>
> Cc: Rob Herring<rob.herring@calxeda•com>
> Cc: Russell King<linux@arm•linux.org.uk>
> Cc: Sascha Hauer<kernel@pengutronix•de>
> Cc: Shiraz Hashim<shiraz.hashim@st•com>
> Cc: Simon Horman<horms@verge•net.au>
> Cc: Srinidhi Kasagar<srinidhi.kasagar@stericsson•com>
> Cc: Stephen Warren<swarren@wwwdotorg•org>
> Cc: Tony Lindgren<tony@atomide•com>
> Cc: Viresh Kumar<viresh.linux@gmail•com>
> ---
>
> Does OMAP5 need to select TWD? I suspect not if it uses the
> architected timers.
>
Nope. OMAP5 don't use TWD. Infact the external SCU is also used
for A9 SOCs. You might want to check other A15 SOCS for SCU as
well.
[..]
> arch/arm/mach-omap2/Kconfig | 4 ++++
[..]
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index a6219ea..b618748 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -58,7 +58,9 @@ config ARCH_OMAP4
> select CPU_V7
> select ARM_GIC
> select HAVE_SMP
> + select HAVE_ARM_SCU if SMP
> select LOCAL_TIMERS if SMP
> + select HAVE_ARM_TWD if LOCAL_TIMERS
> select PL310_ERRATA_588369
> select PL310_ERRATA_727915
> select ARM_ERRATA_720789
Ok.
> @@ -75,6 +77,8 @@ config SOC_OMAP5
> select CPU_V7
> select ARM_GIC
> select HAVE_SMP
> + select HAVE_ARM_SCU if SMP
> + select HAVE_ARM_TWD if LOCAL_TIMERS
> select ARM_CPU_SUSPEND if PM
> select SOC_HAS_REALTIME_COUNTER
> select ARM_ARCH_TIMER
Drop this change.
With that fixed, for OMAP changes
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti•com>
next prev parent reply other threads:[~2012-10-04 9:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 8:50 [PATCH] ARM: Push selects for TWD/SCU into machine entries Stephen Boyd
2012-10-04 8:52 ` viresh kumar
2012-10-04 9:11 ` Santosh Shilimkar [this message]
2012-10-04 19:01 ` Stephen Boyd
2012-10-05 1:12 ` Simon Horman
2012-10-05 6:42 ` Santosh Shilimkar
2012-10-04 13:05 ` Rob Herring
2012-10-04 19:22 ` Stephen Boyd
2012-10-08 12:56 ` Rob Herring
2012-10-05 1:13 ` Simon Horman
2012-10-08 12:15 ` Pawel Moll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506D52D2.9060105@ti.com \
--to=santosh.shilimkar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox