From: nsekhar@ti•com (Sekhar Nori)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 01/13] calk: davinci - add Main PLL clock driver
Date: Thu, 11 Oct 2012 15:45:47 +0530 [thread overview]
Message-ID: <50769C53.8030405@ti.com> (raw)
In-Reply-To: <3E54258959B69E4282D79E01AB1F32B7041FB712@DFLE12.ent.ti.com>
On 10/10/2012 8:04 PM, Karicheri, Muralidharan wrote:
>>>> +struct clk *clk_register_davinci_pll(struct device *dev, const char *name,
>>>> + const char *parent_name,
>>>> + struct clk_davinci_pll_data *pll_data) {
>>>> + struct clk_init_data init;
>>>> + struct clk_davinci_pll *pll;
>>>> + struct clk *clk;
>>>> +
>>>> + if (!pll_data)
>>>> + return ERR_PTR(-ENODEV);
>>>> +
>>>> + pll = kzalloc(sizeof(*pll), GFP_KERNEL);
>>>> + if (!pll)
>>>> + return ERR_PTR(-ENOMEM);
>>>> + init.name = name;
>>>> + init.ops = &clk_pll_ops;
>>>> + init.flags = pll_data->flags;
>>>> + init.parent_names = (parent_name ? &parent_name : NULL);
>>>> + init.num_parents = (parent_name ? 1 : 0);
>>>> +
>>>> + pll->pll_data = pll_data;
>>>> + pll->hw.init = &init;
>>>> +
>>>> + clk = clk_register(NULL, &pll->hw);
>>>> + if (IS_ERR(clk))
>>>> + kfree(pll);
>>>> +
>>>> + return clk;
>>>> +}
>>>
>>> I guess there is an an "unregister" required as well which will free the pll memory
>>> allocated above and unregister the clock? Not sure if you would ever unregister a PLL,
>>> but providing this will probably help symmetry.
> Sekhar,
>
> clk_unregister() itself is a null statement in clk.c. Besides none of the clk drivers presently have implemented the unregister(). So I believe this is unnecessary.
I am ok with this.
> BTW, please review the v2 patch for the rest of the series. For the one you have already reviewed, it should be fine.
Okay. I see those now. BTW, this series also has a v2 in its 0/13. Are
there any differences between this and the other v2, or is that merely a
resend?
Thanks,
Sekhar
next prev parent reply other threads:[~2012-10-11 10:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1348682889-9509-1-git-send-email-m-karicheri2@ti.com>
[not found] ` <1348682889-9509-2-git-send-email-m-karicheri2@ti.com>
2012-09-27 13:19 ` [PATCH 01/13] clk: davinci - add Main PLL clock driver Linus Walleij
2012-09-28 20:12 ` [linux-keystone] " Karicheri, Muralidharan
2012-10-10 12:02 ` Sekhar Nori
2012-10-10 14:34 ` [PATCH 01/13] calk: " Karicheri, Muralidharan
2012-10-11 10:15 ` Sekhar Nori [this message]
2012-10-11 14:07 ` Karicheri, Muralidharan
2012-10-11 10:35 ` [PATCH 01/13] clk: " Sekhar Nori
2012-10-11 14:10 ` Karicheri, Muralidharan
[not found] ` <1348682889-9509-3-git-send-email-m-karicheri2@ti.com>
2012-10-10 12:35 ` [PATCH 02/13] clk: davinci - add PSC " Sekhar Nori
2012-10-10 12:45 ` Sekhar Nori
2012-10-10 14:19 ` Karicheri, Muralidharan
2012-10-10 14:35 ` Karicheri, Muralidharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50769C53.8030405@ti.com \
--to=nsekhar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox