From: nsekhar@ti•com (Sekhar Nori)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 01/13] clk: davinci - add Main PLL clock driver
Date: Thu, 11 Oct 2012 16:33:58 +0530 [thread overview]
Message-ID: <5076A79E.80502@ti.com> (raw)
In-Reply-To: <1348683037-9705-2-git-send-email-m-karicheri2@ti.com>
On 9/26/2012 11:40 PM, Murali Karicheri wrote:
> +struct clk_davinci_pll_data {
> + /* physical addresses set by platform code */
> + u32 phy_pllm;
> + /* if PLL has a prediv register this should be non zero */
> + u32 phy_prediv;
> + /* if PLL has a postdiv register this should be non zero */
> + u32 phy_postdiv;
"phys" is typically used for physical addresses. I couldn't immediately
related this to physical address when I looked at this variable outside
of this file.
Also, physical addresses should be of type phys_addr_t.
> + /* mapped addresses. should be initialized by */
> + void __iomem *pllm;
> + void __iomem *prediv;
> + void __iomem *postdiv;
> + u32 pllm_mask;
> + u32 prediv_mask;
> + u32 postdiv_mask;
> + u32 num;
Wondering what num is for? May be it will be clear once you document the
complete structure as Linus suggested.
> + /* framework flags */
> + u32 flags;
> + /* pll flags */
> + u32 pll_flags;
> + /* use this value for prediv */
> + u32 fixed_prediv;
Why is this called "fixed". Isn't this the pre-divider value that user
can configure? Also, shouldn't there be a post-divider value that you
need as well.
> + /* multiply PLLM by this factor. By default most SOC set this to zero
> + * that translates to a multiplier of 1 and incrementer of 1.
> + * To override default, set this factor
> + */
> + u32 pllm_multiplier;
'm' in pllm stands for multiplier. So, instead of calling it
"pllm_multiplier", call it "pllm_val" instead?
Sorry about late comments on this, looks like I missed looking at this
structure altogether yesterday and had to go back to this only when I
tried understanding whats going on in 4/13
Thanks,
Sekhar
next parent reply other threads:[~2012-10-11 11:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1348683037-9705-1-git-send-email-m-karicheri2@ti.com>
[not found] ` <1348683037-9705-2-git-send-email-m-karicheri2@ti.com>
2012-10-11 11:03 ` Sekhar Nori [this message]
[not found] ` <1348683037-9705-10-git-send-email-m-karicheri2@ti.com>
2012-10-11 12:25 ` [PATCH v2 09/13] ARM: davinci - update the dm644x soc code to use common clk drivers Sekhar Nori
2012-10-11 14:58 ` Karicheri, Muralidharan
2012-10-12 10:43 ` Sekhar Nori
2012-10-15 15:51 ` Karicheri, Muralidharan
2012-10-16 5:51 ` Sekhar Nori
[not found] ` <1348683037-9705-5-git-send-email-m-karicheri2@ti.com>
2012-10-11 12:31 ` [PATCH v2 04/13] clk: davinci - common clk driver initialization Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5076A79E.80502@ti.com \
--to=nsekhar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox