From: voice.shen@atmel•com (Bo Shen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] i2c: change the id to let the i2c device work
Date: Fri, 12 Oct 2012 15:55:32 +0800 [thread overview]
Message-ID: <5077CCF4.7070104@atmel.com> (raw)
In-Reply-To: <20121012091427.0d7b2bed@endymion.delvare>
Hi Jean Delvare,
On 10/12/2012 15:14, Jean Delvare wrote:
> On Fri, 12 Oct 2012 14:53:02 +0900, Mark Brown wrote:
>> On Fri, Oct 12, 2012 at 01:45:48PM +0800, Bo Shen wrote:
>>> So, in this case, if the id = -1, i2c core will dynamically assign a
>>> bus id to this bus when running, the dynamically assigned bus id is
>>> unknown when writing the code. So, when we use
>>> i2c_register_board_info(int busnum, ...) to register device on
>>> busnum. we don't know which value to be use.
>>
>> The I2C bus number assigned to the controller should be independant of
>> the platform device ID used to register the device; a better fix if this
>> is an issue would be to update the i2c-gpio driver to allow a fixed bus
>> number to be specified in platform data.
>
> i2c-gpio does support this already.
vim I only see the i2c-gpio platform data structure as following:
--<---------------------
struct i2c_gpio_platform_data {
unsigned int sda_pin;
unsigned int scl_pin;
int udelay;
int timeout;
unsigned int sda_is_open_drain:1;
unsigned int scl_is_open_drain:1;
unsigned int scl_is_output_only:1;
};
-->---------------------
So, how to allow a fixed bus number to be specified in platform data?
next prev parent reply other threads:[~2012-10-12 7:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 2:34 [PATCH] i2c: change the id to let the i2c device work Bo Shen
2012-10-12 4:40 ` Mark Brown
2012-10-12 4:57 ` Bo Shen
2012-10-12 5:14 ` Mark Brown
2012-10-12 5:45 ` Bo Shen
2012-10-12 5:53 ` Mark Brown
2012-10-12 6:42 ` Bo Shen
2012-10-12 7:14 ` Jean Delvare
2012-10-12 7:55 ` Bo Shen [this message]
2012-10-12 8:05 ` Jean Delvare
2012-10-12 8:21 ` Mark Brown
2012-10-12 9:02 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5077CCF4.7070104@atmel.com \
--to=voice.shen@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox