From: jon-hunter@ti•com (Jon Hunter)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ARM: dts: OMAP: Add counter-32k nodes
Date: Thu, 18 Oct 2012 09:27:30 -0500 [thread overview]
Message-ID: <508011D2.30806@ti.com> (raw)
In-Reply-To: <508010E1.6010102@ti.com>
On 10/18/2012 09:23 AM, Benoit Cousson wrote:
> Hi Jon,
>
> This looks good to me, I just have a minor nit comment.
>
> On 10/17/2012 08:33 PM, Jon Hunter wrote:
>> Adds the counter-32k timers nodes present in OMAP2/3/4 devices and
>> device-tree binding documentation for OMAP counter-32k.
>>
>> Signed-off-by: Jon Hunter <jon-hunter@ti•com>
>> ---
>> .../devicetree/bindings/arm/omap/counter32k.txt | 15 +++++++++++++++
>> arch/arm/boot/dts/omap2420.dtsi | 6 ++++++
>> arch/arm/boot/dts/omap2430.dtsi | 6 ++++++
>> arch/arm/boot/dts/omap3.dtsi | 6 ++++++
>> arch/arm/boot/dts/omap4.dtsi | 6 ++++++
>> 5 files changed, 39 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/arm/omap/counter32k.txt
>>
>> diff --git a/Documentation/devicetree/bindings/arm/omap/counter32k.txt b/Documentation/devicetree/bindings/arm/omap/counter32k.txt
>> new file mode 100644
>> index 0000000..1983fae
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/omap/counter32k.txt
>> @@ -0,0 +1,15 @@
>> +OMAP Counter-32K bindings
>> +
>> +Required properties:
>> +- compatible: Must be "ti,omap-counter32k" for OMAP controllers
>> +- reg: Contains timer register address range (base address and length)
>> +- ti,hwmods: Name of the hwmod associated to the counter, which is typically
>> + "counter_32k"
>> +
>> +Example:
>> +
>> +counter32k: counter32k at 4a304000 {
>> + compatible = "ti,omap-counter32k";
>> + reg = <0x4a304000 0x001f>;
>> + ti,hwmods = "counter_32k";
>> +};
>> diff --git a/arch/arm/boot/dts/omap2420.dtsi b/arch/arm/boot/dts/omap2420.dtsi
>> index 5f68a70..082193f 100644
>> --- a/arch/arm/boot/dts/omap2420.dtsi
>> +++ b/arch/arm/boot/dts/omap2420.dtsi
>> @@ -14,6 +14,12 @@
>> compatible = "ti,omap2420", "ti,omap2";
>>
>> ocp {
>> + counter32k: counter32k at 48004000 {
>
> I'd rather use "counter" as generic type to be consistent with the timer
> type we are already using.
>
> + counter32k: counter at 48004000 {
Sounds good. Will update.
Cheers
Jon
next prev parent reply other threads:[~2012-10-18 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 18:33 [PATCH 0/2] ARM: OMAP2+: Add device-tree support for 32kHz counter Jon Hunter
2012-10-17 18:33 ` [PATCH 1/2] ARM: dts: OMAP: Add counter-32k nodes Jon Hunter
2012-10-18 14:23 ` Benoit Cousson
2012-10-18 14:27 ` Jon Hunter [this message]
2012-10-17 18:33 ` [PATCH 2/2] ARM: OMAP2+: Add device-tree support for 32kHz counter Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508011D2.30806@ti.com \
--to=jon-hunter@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox