From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/5] ARM: tegra: fix clock entry of slink controller
Date: Thu, 18 Oct 2012 16:43:56 -0600 [thread overview]
Message-ID: <5080862C.9030203@wwwdotorg.org> (raw)
In-Reply-To: <1350557795-31487-4-git-send-email-ldewangan@nvidia.com>
On 10/18/2012 04:56 AM, Laxman Dewangan wrote:
> Fix the driver name, connection name and clock name
> for slink controller clocks in clock table of
> Tegra20 and Tegra30.
The patch subject isn't entirely accurate here; this patch isn't just
about fixing clock entries.
> diff --git a/arch/arm/mach-tegra/board-dt-tegra20.c b/arch/arm/mach-tegra/board-dt-tegra20.c
> @@ -90,6 +90,10 @@ struct of_dev_auxdata tegra20_auxdata_lookup[] __initdata = {
> &tegra_ehci3_pdata),
> OF_DEV_AUXDATA("nvidia,tegra20-apbdma", TEGRA_APB_DMA_BASE, "tegra-apbdma", NULL),
> OF_DEV_AUXDATA("nvidia,tegra20-pwm", TEGRA_PWFM_BASE, "tegra-pwm", NULL),
> + OF_DEV_AUXDATA("nvidia,tegra20-slink", TEGRA_SLINK1_BASE, "spi-tegra-slink.0", NULL),
Here, can't we just use the existing device names in the clock files...
So we can completely drop the changes to these two files:
> diff --git a/arch/arm/mach-tegra/tegra20_clocks_data.c b/arch/arm/mach-tegra/tegra20_clocks_data.c
> diff --git a/arch/arm/mach-tegra/tegra30_clocks_data.c b/arch/arm/mach-tegra/tegra30_clocks_data.c
The device names will hopefully be irrelevant once we're able to use
DT-based clock lookups.
next prev parent reply other threads:[~2012-10-18 22:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 10:56 [PATCH 0/5] ARM: tegra: Enable SLINK controller driver Laxman Dewangan
2012-10-18 10:56 ` [PATCH 1/5] ARM: tegra: Add slink controller base address Laxman Dewangan
2012-10-18 22:39 ` Stephen Warren
2012-10-19 9:06 ` Laxman Dewangan
2012-10-18 10:56 ` [PATCH 2/5] ARM: tegra: dts: add slink controller dt entry Laxman Dewangan
2012-10-18 22:41 ` Stephen Warren
2012-10-19 9:10 ` Laxman Dewangan
2012-10-19 15:56 ` Stephen Warren
2012-10-24 3:26 ` Vinod Koul
2012-10-18 10:56 ` [PATCH 3/5] ARM: tegra: fix clock entry of slink controller Laxman Dewangan
2012-10-18 22:43 ` Stephen Warren [this message]
2012-10-19 9:13 ` Laxman Dewangan
2012-10-19 15:59 ` Stephen Warren
2012-10-18 10:56 ` [PATCH 4/5] ARM: tegra: dts: cardhu: enable SLINK4 Laxman Dewangan
2012-10-18 10:56 ` [PATCH 5/5] ARM: tegra: config: enable spi driver for Tegra SLINK controller Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5080862C.9030203@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox