From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] pinctrl: reserve pins when states are activated
Date: Fri, 19 Oct 2012 10:18:47 -0600 [thread overview]
Message-ID: <50817D67.10900@wwwdotorg.org> (raw)
In-Reply-To: <1350651909-5337-1-git-send-email-linus.walleij@stericsson.com>
On 10/19/2012 07:05 AM, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro•org>
>
> This switches the way that pins are reserved for multiplexing:
>
> We used to do this when the map was parsed, at the creation of
> the settings inside the pinctrl handle, in pinmux_map_to_setting().
>
> However this does not work for us, because we want to use the
> same set of pins with different devices at different times: the
> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
> @@ -689,7 +691,6 @@ static void pinctrl_put_locked(struct pinctrl *p, bool inlist)
> case PIN_MAP_TYPE_MUX_GROUP:
> if (state == p->state)
> pinmux_disable_setting(setting);
> - pinmux_free_setting(setting);
Personally, I would keep that function, and just remove the body. I
believe that even though it currently doesn't have to do anything, it
provides documentation for where any required cleanup would be placed if
needed in the future.
If you still want to remove the function, pinconf_free_setting() should
also be removed, since that's empty right now.
Irrespective,
Acked-by: Stephen Warren <swarren@nvidia•com>
next prev parent reply other threads:[~2012-10-19 16:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 13:05 [PATCH v2] pinctrl: reserve pins when states are activated Linus Walleij
2012-10-19 14:51 ` Jean-Nicolas GRAUX
2012-10-19 16:18 ` Stephen Warren [this message]
2012-10-19 18:10 ` Tony Lindgren
2012-10-22 8:21 ` Linus Walleij
2012-10-22 19:07 ` Tony Lindgren
2012-10-23 8:58 ` Linus Walleij
2012-10-22 20:30 ` Stephen Warren
2012-10-23 9:31 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50817D67.10900@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox