From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 3/3] ARM: tegra: move debug-macro.S to include/debug
Date: Fri, 19 Oct 2012 10:37:09 -0600 [thread overview]
Message-ID: <508181B5.3020207@wwwdotorg.org> (raw)
In-Reply-To: <20121018095328.GS21164@n2100.arm.linux.org.uk>
On 10/18/2012 03:53 AM, Russell King - ARM Linux wrote:
> On Wed, Oct 17, 2012 at 03:12:17PM -0600, Stephen Warren wrote:
>> That implies we really do need to keep the two pieces of code completely
>> in sync, so a shared header is the right way to go. It also implies that
>> having duplicate mappings of the same physical address doesn't cause any
>> immediate obvious catastrophic problems.
>>
>> Ways we might avoid files in arch/arm/include/debug having to use
>> relative include paths to pick up that header are:
>
> Why not take the opposite approach. Treat the platform as setting up the
> addresses for the UART. Then arrange for the debug macros to match that.
Well, wouldn't the debug macros match it by including a common header
file that defined the virtual address:-)
> Or we define a common virtual address for debug UARTs (which platforms
> would not be able to use).
That seems like good idea.
>> b) Rework debug-macro.S so that it isn't an include file, but rather a
>> regular top-level file.
>
> No, that won't work. It's used in two places - the kernel and the
> decompressor. Hence why it is an include file (it's not an include
> file just for the fun of it.)
Can't the file just be compiled twice by the two different Makefiles?
next prev parent reply other threads:[~2012-10-19 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 19:07 [PATCH V2 1/3] ARM: tegra: simplify DEBUG_LL UART selection options Stephen Warren
2012-10-15 19:07 ` [PATCH V2 2/3] ARM: tegra: make debug-macro.S work standalone Stephen Warren
2012-10-15 19:07 ` [PATCH V2 3/3] ARM: tegra: move debug-macro.S to include/debug Stephen Warren
2012-10-17 14:03 ` Arnd Bergmann
2012-10-17 14:38 ` Rob Herring
2012-10-17 16:22 ` Stephen Warren
2012-10-17 21:12 ` Stephen Warren
2012-10-18 9:53 ` Russell King - ARM Linux
2012-10-19 16:37 ` Stephen Warren [this message]
2012-10-18 13:47 ` Rob Herring
2012-10-18 13:54 ` Russell King - ARM Linux
2012-10-18 14:15 ` Rob Herring
2012-10-19 16:40 ` Stephen Warren
2012-10-17 23:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508181B5.3020207@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox