From: zonque@gmail•com (Daniel Mack)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] RTC: omap-rtc: enable pm_runtime
Date: Sun, 21 Oct 2012 21:51:37 +0200 [thread overview]
Message-ID: <50845249.2000007@gmail.com> (raw)
In-Reply-To: <C8443D0743D26F4388EA172BF4E2A7A93EA00B18@DBDE01.ent.ti.com>
On 19.10.2012 12:58, Mohammed, Afzal wrote:
> Hi Daniel,
>
> On Thu, Oct 18, 2012 at 22:03:13, Hiremath, Vaibhav wrote:
>> On Thu, Oct 18, 2012 at 21:49:44, Daniel Mack wrote:
>>> On 18.10.2012 18:12, Vaibhav Hiremath wrote:
>
>>>> It would be really helpful if you could test these patches and ack them.
>
>>> Ok, will do tomorrow. What's missing there is support for writing to the
>>> OMAP_RTC_OSC_REG (path 3/3 in my series). Would like me to rebase the
>>> functionality? I need thatkind of setup for my board ...
>
>> This is bit tricky and required more discussion before merging it,
>> let me reopen the old discussion which I had started some time back -
>>
>>
>> RTC OSC clock is required to configure clocksource systemtimer for the
>> kernel, and it is important when you get into PM related features.
>>
>> Please refer the below commit for more reference,
>>
>> http://marc.info/?l=u-boot&m=135057734713796&w=2
>
> Newer version (v4) of omap rtc patches for am335x has been
> posted, "rtc: omap dt support (for am33xx)".
> In case you can test, please do it over the new series.
>
> You would need also need DT patch that adds DT node to
> test (it has been separated from the series as it is
> felt that it should not be part of same series),
> "arm/dts: am33xx rtc node"
Agreed. I tested your patches and they do basically the same thing than
mine. You can take my
Tested-by: Daniel Mack <zonque@gmail•com>
on all patches in this series except for 2/5 which I didn't test as I
don't have any Davinci platform.
> If you are using mainline uboot, you would need the fix as
> mentioned by Vaibhav H (as in the link he provided above),
> expecting it to reach uboot mainline soon.
>
> If the above is being attempted to achieve in Kernel it
> would cause 2-3 seconds delay in boot time (else it had
> to be made a module), please refer link provided by
> Vaibhav H for more details.
>
> else you can do in current mainline uboot,
>
> mw.l 0x44e3e06c 0x83e70b13
> mw.l 0x44e3e070 0x95a4f1e0
> mw.b 0x44e3e054 0x48
>
> and then boot kernel.
I'm surprised that survives the kernel boot, but I'll give it a try. In
case you want to add that logic to the kernel as well, please copy me in
the discussion :)
Thanks,
Daniel
next prev parent reply other threads:[~2012-10-21 19:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 15:53 [PATCH 1/3] RTC: omap-rtc: enable for SOC_AM33XX Daniel Mack
2012-10-18 15:53 ` [PATCH 2/3] RTC: omap-rtc: enable pm_runtime Daniel Mack
2012-10-18 16:12 ` Vaibhav Hiremath
2012-10-18 16:19 ` Daniel Mack
2012-10-18 16:33 ` Hiremath, Vaibhav
2012-10-19 10:58 ` Mohammed, Afzal
2012-10-21 19:51 ` Daniel Mack [this message]
2012-10-22 5:59 ` Hiremath, Vaibhav
2012-10-18 15:53 ` [PATCH 3/3] RTC: omap-rtc: add DT bindings Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50845249.2000007@gmail.com \
--to=zonque@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox