From: kishon@ti•com (kishon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv9 8/8] ARM: OMAP4: USB: power down MUSB PHY if not used
Date: Mon, 22 Oct 2012 14:24:30 +0530 [thread overview]
Message-ID: <508509C6.10708@ti.com> (raw)
In-Reply-To: <1350571199.2143.53.camel@sokoban>
Hi,
On Thursday 18 October 2012 08:09 PM, Tero Kristo wrote:
> On Thu, 2012-10-18 at 16:53 +0300, Felipe Balbi wrote:
>> hi,
>>
>> On Thu, Oct 18, 2012 at 03:18:04PM +0300, Tero Kristo wrote:
>>>>> +static int __init omap4430_phy_power_down(void)
>>>>> +{
>>>>> + void __iomem *ctrl_base;
>>>>> +
>>>>> + if (!cpu_is_omap44xx())
>>>>> + return 0;
>>>>> +
>>>>> + ctrl_base = ioremap(OMAP443X_SCM_BASE, SZ_1K);
>>>>> + if (!ctrl_base) {
>>>>> + pr_err("control module ioremap failed\n");
>>>>> + return -ENOMEM;
>>>>> + }
>>>>> +
>>>>> + /* Power down the phy */
>>>>> + __raw_writel(PHY_PD, ctrl_base + CONTROL_DEV_CONF);
>>>>> +
>>>>> + iounmap(ctrl_base);
>>>>> +
>>>>> + return 0;
>>>>> +}
>>>>> +early_initcall(omap4430_phy_power_down);
>>>>> +#endif
>>>>
>>>> I think you could do it even if the driver is enabled.
>>>
>>> Actually not at least now, it looks like the driver is not controlling
>>> this bit at all, so the driver would fail if we do this.
>>
>> then we can consider that a bug in the driver. Kishon, I thought you had
>> added SCM address space to PHY driver for this particular reason until
>> we get SCM driver, wasn't it ??
>
> Yes, I would say its a bug in the driver.
No. It's done in the driver (omap_usb_phy_power() in
drivers/usb/phy/omap-usb2.c). We explicitly power off the phy during
probe in the driver.
However we need this disable
> mechanism for the case where we don't have the driver also (which is the
> default config for omap.)
Agree.
Thanks
Kishon
next prev parent reply other threads:[~2012-10-22 8:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 9:20 [PATCHv9 0/8] ARM: OMAP4: core retention support Tero Kristo
2012-10-18 9:20 ` [PATCHv9 1/8] ARM: OMAP: hwmod: Add support for per hwmod/module context lost count Tero Kristo
2012-10-27 3:00 ` Paul Walmsley
2012-11-21 23:05 ` Paul Walmsley
2012-10-18 9:20 ` [PATCHv9 2/8] ARM: OMAP4: PM: add errata support Tero Kristo
2012-11-05 22:36 ` Kevin Hilman
2012-11-06 21:52 ` Kevin Hilman
2012-11-07 10:11 ` Tero Kristo
2012-10-18 9:20 ` [PATCHv9 3/8] ARM: OMAP4460: Workaround for ROM bug because of CA9 r2pX GIC control register change Tero Kristo
2012-10-18 9:20 ` [PATCHv9 4/8] ARM: OMAP4: suspend: Program all domains to retention Tero Kristo
2012-10-18 9:20 ` [PATCHv9 5/8] ARM: OMAP4: PM: put all domains to OSWR during suspend Tero Kristo
2012-10-18 9:20 ` [PATCHv9 6/8] ARM: OMAP4: retrigger localtimers after re-enabling gic Tero Kristo
2012-10-27 2:51 ` Paul Walmsley
2012-11-05 22:25 ` Kevin Hilman
2012-11-06 9:15 ` Tero Kristo
2012-10-18 9:20 ` [PATCHv9 7/8] ARM: OMAP: PM: update target fpwrst to what pwrdm can reach Tero Kristo
2012-10-18 9:20 ` [PATCHv9 8/8] ARM: OMAP4: USB: power down MUSB PHY if not used Tero Kristo
2012-10-18 10:33 ` Felipe Balbi
2012-10-18 12:18 ` Tero Kristo
2012-10-18 13:53 ` Felipe Balbi
2012-10-18 14:39 ` Tero Kristo
2012-10-18 14:41 ` Felipe Balbi
2012-10-22 8:54 ` kishon [this message]
2012-10-22 9:07 ` Felipe Balbi
2012-10-22 9:25 ` kishon
2012-10-27 2:52 ` Paul Walmsley
2012-10-27 3:02 ` [PATCHv9 0/8] ARM: OMAP4: core retention support Paul Walmsley
2012-11-05 22:23 ` Kevin Hilman
2012-11-06 9:18 ` Tero Kristo
2012-11-06 21:19 ` Kevin Hilman
2012-11-07 10:17 ` Tero Kristo
2012-11-12 14:41 ` Tero Kristo
2012-11-13 19:18 ` Kevin Hilman
2012-11-07 18:35 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508509C6.10708@ti.com \
--to=kishon@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox