From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/5] arm: mvebu: Added IPI support via doorbells
Date: Mon, 22 Oct 2012 23:11:02 +0200 [thread overview]
Message-ID: <5085B666.1040500@free-electrons.com> (raw)
In-Reply-To: <20121022200708.GO21046@lunn.ch>
On 10/22/2012 10:07 PM, Andrew Lunn wrote:
> On Mon, Oct 22, 2012 at 09:07:34PM +0200, Gregory CLEMENT wrote:
>> On 10/22/2012 07:30 PM, Andrew Lunn wrote:
>>> On Mon, Oct 22, 2012 at 07:02:45PM +0200, Gregory CLEMENT wrote:
>>>> From: Yehuda Yitschak <yehuday@marvell•com>
>>>>
>>>> Signed-off-by: Yehuda Yitschak <yehuday@marvell•com>
>>>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
>>>> ---
>>>> arch/arm/boot/dts/armada-xp.dtsi | 2 +-
>>>> arch/arm/mach-mvebu/armada-370-xp.h | 10 ++++
>>>> arch/arm/mach-mvebu/irq-armada-370-xp.c | 92 +++++++++++++++++++++++++++++--
>>>> 3 files changed, 97 insertions(+), 7 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/armada-xp.dtsi b/arch/arm/boot/dts/armada-xp.dtsi
>>>> index f521ed8..531619f 100644
>>>> --- a/arch/arm/boot/dts/armada-xp.dtsi
>>>> +++ b/arch/arm/boot/dts/armada-xp.dtsi
>>>> @@ -24,7 +24,7 @@
>>>>
>>>> mpic: interrupt-controller at d0020000 {
>>>> reg = <0xd0020a00 0x1d0>,
>>>> - <0xd0021870 0x58>;
>>>> + <0xd0021070 0x58>;
>>>> };
>>>
>>> Hi Gregory
>>>
>>> Is this a bug fix needed for 3.7?
>>>
>>> Andrew
>>>
>> I don't think so.
>> We extended the reg map to be able to use registers only used for SMP.
>> When we didn't have SMP support the mapping was correct, and now by
>> introducing SMP we extend it.
>
> The length has stayed the same, so its not extended. Its now 0x800
> bytes earlier in the address space.
>
Right!
I didn't check it, sorry.
The correct explanation is that the offset +21070 is a CPU virtual offset.
That means that depending of the CPU core which will access to this register,
the controller will internally change the offset automagically to point the
correct offset.
I should have added an explanation in the commit log. I will do it for V2.
> Andrew
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-10-22 21:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 17:02 [PATCH 0/5] SMP support for Armada XP Gregory CLEMENT
2012-10-22 17:02 ` [PATCH 1/5] arm: mvebu: Added support for coherency fabric in mach-mvebu Gregory CLEMENT
2012-10-22 17:02 ` [PATCH 2/5] arm: mvebu: Added initial support for power managmement service unit Gregory CLEMENT
2012-10-22 17:02 ` [PATCH 3/5] arm: mvebu: Added IPI support via doorbells Gregory CLEMENT
2012-10-22 17:30 ` Andrew Lunn
2012-10-22 19:07 ` Gregory CLEMENT
2012-10-22 20:07 ` Andrew Lunn
2012-10-22 21:11 ` Gregory CLEMENT [this message]
2012-10-23 5:14 ` Thomas Petazzoni
2012-10-23 5:44 ` Andrew Lunn
2012-10-23 5:50 ` Thomas Petazzoni
2012-10-22 17:02 ` [PATCH 4/5] arm: mm: Added support for PJ4B cpu and init routines Gregory CLEMENT
2012-10-22 17:02 ` [PATCH 5/5] arm: mvebu: Added SMP support for Armada XP Gregory CLEMENT
2012-10-22 18:45 ` Andrew Lunn
2012-10-23 9:11 ` Gregory CLEMENT
2012-10-23 9:30 ` Andrew Lunn
2012-10-23 10:43 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5085B666.1040500@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox