From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] arm: mvebu: adding SATA support: dt binding and config update
Date: Wed, 24 Oct 2012 16:45:32 +0200 [thread overview]
Message-ID: <5087FF0C.7050303@free-electrons.com> (raw)
In-Reply-To: <20121024140801.GB11837@lunn.ch>
On 10/24/2012 04:08 PM, Andrew Lunn wrote:
> On Wed, Oct 24, 2012 at 03:49:21PM +0200, Gregory CLEMENT wrote:
>> From: Lior Amsalem <alior@marvell•com>
>>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
>> Signed-off-by: Lior Amsalem <alior@marvell•com>
>> ---
>> arch/arm/boot/dts/armada-370-db.dts | 3 +++
>> arch/arm/boot/dts/armada-370-xp.dtsi | 10 ++++++++++
>> arch/arm/boot/dts/armada-xp-db.dts | 3 +++
>> arch/arm/configs/mvebu_defconfig | 7 +++++++
>> 4 files changed, 23 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/armada-370-db.dts b/arch/arm/boot/dts/armada-370-db.dts
>> index 4a31b03..2a2aa75 100644
>> --- a/arch/arm/boot/dts/armada-370-db.dts
>> +++ b/arch/arm/boot/dts/armada-370-db.dts
>> @@ -34,5 +34,8 @@
>> clock-frequency = <200000000>;
>> status = "okay";
>> };
>> + sata at d00a0000 {
>> + status = "okay";
>> + };
>> };
>> };
>> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
>> index 94b4b9e..3f08233 100644
>> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
>> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
>> @@ -69,6 +69,16 @@
>> compatible = "marvell,armada-addr-decoding-controller";
>> reg = <0xd0020000 0x258>;
>> };
>> +
>> + sata at d00a0000 {
>> + compatible = "marvell,orion-sata";
>> + reg = <0xd00a0000 0x2400>;
>> + interrupts = <55>;
>> + nr-ports = <2>;
>> + clocks = <&coreclk 0>;//, <&coreclk 0>;
>> + status = "disabled";
>> + };
>> +
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/armada-xp-db.dts b/arch/arm/boot/dts/armada-xp-db.dts
>> index b1fc728..b0db9a3 100644
>> --- a/arch/arm/boot/dts/armada-xp-db.dts
>> +++ b/arch/arm/boot/dts/armada-xp-db.dts
>> @@ -46,5 +46,8 @@
>> clock-frequency = <250000000>;
>> status = "okay";
>> };
>> + sata at d00a0000 {
>> + status = "okay";
>> + };
>> };
>> };
>
> Hi Gregory
>
> Should there be some pinctrl setup somewhere, to ensure the pins used
> for SATA are really setup up for SATA?
Yes you're right we should not depend of the bootloader configuration.
>
> Also, for kirkwood, the number of SATA ports varies. So we don't
> define it in the base kirkwood.dtsi and leave each board to set it.
> Do we want to be consistent between kirkwood and 370/xp?
Yes sure. I will move it from dtsi to dts.
>
> Thanks
> Andrew
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2012-10-24 14:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 13:49 [PATCH 0/2] Adding SATA support for Armada 370/XP Gregory CLEMENT
2012-10-24 13:49 ` [PATCH 1/2] arm: mvebu: increase atomic coherent pool size for armada 370/XP Gregory CLEMENT
2012-10-25 5:29 ` Marek Szyprowski
2012-10-25 11:27 ` Arnd Bergmann
2012-10-25 11:43 ` Thomas Petazzoni
2012-10-25 13:46 ` Arnd Bergmann
2012-10-25 14:09 ` Thomas Petazzoni
2012-10-30 7:19 ` Marek Szyprowski
2012-10-24 13:49 ` [PATCH 2/2] arm: mvebu: adding SATA support: dt binding and config update Gregory CLEMENT
2012-10-24 14:01 ` Thomas Petazzoni
2012-10-24 14:05 ` Gregory CLEMENT
2012-10-25 13:18 ` Jason Cooper
2012-10-25 13:21 ` Thomas Petazzoni
2012-10-25 13:34 ` Gregory CLEMENT
2012-10-25 13:57 ` Rob Herring
2012-10-25 16:00 ` Gregory CLEMENT
2012-10-25 13:35 ` Jason Cooper
2012-10-25 13:53 ` Rob Herring
2012-10-25 14:11 ` Gregory CLEMENT
2012-10-25 14:27 ` Rob Herring
2012-10-24 14:08 ` Andrew Lunn
2012-10-24 14:45 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5087FF0C.7050303@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox