From: sshtylyov@mvista•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/6] ARM: davinci: Changed pr_warning() to pr_warn()
Date: Fri, 26 Oct 2012 13:46:27 +0400 [thread overview]
Message-ID: <508A5BF3.2060803@mvista.com> (raw)
In-Reply-To: <1351197357-23528-1-git-send-email-rtivy@ti.com>
Hello.
It's not a good idea to send multiple patches with the same subject.
Actually, in this case it's worth merging all 4 patches into one.
On 26-10-2012 0:35, Robert Tivy wrote:
> Also, while modifying those pr_warning() calls I changed hardcoded
> function names to use '"%s:", __func__' instead
> Signed-off-by: Robert Tivy <rtivy@ti•com>
> ---
> Clean up files that will be otherwise modified in subsequent patch.
> Applies to v3.5 tag (commit 28a33cbc24e4256c143dce96c7d93bf423229f92) of
> Linus' mainline kernel at git.kernel.org.
3.5 is too old. Why not to 3.6 or even 3.7-rc2?
> diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
> index 0149fb4..bbb3c73 100644
> --- a/arch/arm/mach-davinci/board-da850-evm.c
> +++ b/arch/arm/mach-davinci/board-da850-evm.c
[...]
> @@ -1046,21 +1046,19 @@ static int __init da850_evm_config_emac(void)
> }
>
> if (ret)
> - pr_warning("da850_evm_init: cpgmac/rmii mux setup failed: %d\n",
> - ret);
> + pr_warn("%s: cpgmac/rmii mux setup failed: %d\n",
> + __func__, ret);
>
> /* configure the CFGCHIP3 register for RMII or MII */
> __raw_writel(val, cfg_chip3_base);
>
> ret = davinci_cfg_reg(DA850_GPIO2_6);
> if (ret)
> - pr_warning("da850_evm_init:GPIO(2,6) mux setup "
> - "failed\n");
> + pr_warn("%s:GPIO(2,6) mux setup failed\n", __func__);
Worth inserting space after colon here.
WBR, Sergei
next parent reply other threads:[~2012-10-26 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1351197357-23528-1-git-send-email-rtivy@ti.com>
2012-10-26 9:46 ` Sergei Shtylyov [this message]
2012-10-27 0:59 ` [PATCH v2 1/6] ARM: davinci: Changed pr_warning() to pr_warn() Tivy, Robert
2012-10-27 8:52 ` Sekhar Nori
[not found] ` <1351197357-23528-5-git-send-email-rtivy@ti.com>
2012-11-01 13:52 ` [PATCH v2 5/6] ARM: davinci: remoteproc board support for OMAP-L138 DSP Ben Gardiner
2012-11-06 5:02 ` Prabhakar Lad
2012-11-06 19:33 ` Tivy, Robert
2012-11-07 5:20 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508A5BF3.2060803@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox