From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 2/4] arm: mvebu: adding SATA support: dt binding for Armada 370/XP
Date: Fri, 26 Oct 2012 15:47:08 +0200 [thread overview]
Message-ID: <508A945C.4010006@free-electrons.com> (raw)
In-Reply-To: <20121026133446.GM21046@lunn.ch>
On 10/26/2012 03:34 PM, Andrew Lunn wrote:
> On Fri, Oct 26, 2012 at 09:31:54AM -0400, Jason Cooper wrote:
>> On Fri, Oct 26, 2012 at 02:30:47PM +0200, Gregory CLEMENT wrote:
>>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
>>> Signed-off-by: Lior Amsalem <alior@marvell•com>
>>> ---
>>> arch/arm/boot/dts/armada-370-xp.dtsi | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/armada-370-xp.dtsi b/arch/arm/boot/dts/armada-370-xp.dtsi
>>> index 94b4b9e..a911f7a 100644
>>> --- a/arch/arm/boot/dts/armada-370-xp.dtsi
>>> +++ b/arch/arm/boot/dts/armada-370-xp.dtsi
>>> @@ -69,6 +69,15 @@
>>> compatible = "marvell,armada-addr-decoding-controller";
>>> reg = <0xd0020000 0x258>;
>>> };
>>> +
>>> + sata at d00a0000 {
>>> + compatible = "marvell,orion-sata";
>>> + reg = <0xd00a0000 0x2400>;
>>> + interrupts = <55>;
>>> + clocks = <&coreclk 0>;
>>
>> nit. whitespace?
>
> [Don't shoot the messenger]
>
> How about extending checkpatch to check for this? I guess its just
> spaces which should be tabs.
No it is the opposite in fact! On this line it's tabs: 3 tabs of 8
whitespace, so the line start at 24. But as there is a '+', the first
tab is only 7, so it is still start at 24. Whereas for the other lines
it's 24 white spaces, so with the '+' it starts at 25. That's why I
didn't notice it, and if you apply the patch all is fine.
Now, about white spaces vs tab, I don't know what is the rule for .dts
file.
Gregory
next prev parent reply other threads:[~2012-10-26 13:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 12:30 [PATCH V2 0/4] Adding SATA support for Armada 370/XP Gregory CLEMENT
2012-10-26 12:30 ` [PATCH V2 1/4] arm: mvebu: increase atomic coherent pool size for armada 370/XP Gregory CLEMENT
2012-10-26 12:30 ` [PATCH V2 2/4] arm: mvebu: adding SATA support: dt binding for Armada 370/XP Gregory CLEMENT
2012-10-26 13:31 ` Jason Cooper
2012-10-26 13:34 ` Andrew Lunn
2012-10-26 13:47 ` Gregory CLEMENT [this message]
2012-10-26 13:52 ` Andrew Lunn
2012-10-26 14:57 ` Thomas Petazzoni
2012-10-26 15:02 ` Jason Cooper
2012-10-26 15:06 ` Gregory CLEMENT
2012-10-26 12:30 ` [PATCH V2 3/4] arm: mvebu: adding SATA support: configs update Gregory CLEMENT
2012-10-26 12:30 ` [PATCH V2 4/4] arm: mvebu: adding SATA support: dt binding for Armada 370/XP boards Gregory CLEMENT
2012-10-26 12:39 ` [PATCH V2 0/4] Adding SATA support for Armada 370/XP Andrew Lunn
2012-10-26 12:48 ` Thomas Petazzoni
2012-10-26 12:54 ` Andrew Lunn
2012-10-26 12:55 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508A945C.4010006@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox