From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] arm: bcm2835: convert to the irqchip infrastructure
Date: Sat, 27 Oct 2012 20:23:11 -0600 [thread overview]
Message-ID: <508C970F.9000305@wwwdotorg.org> (raw)
In-Reply-To: <1351356317-16758-2-git-send-email-thomas.petazzoni@free-electrons.com>
On 10/27/2012 10:45 AM, Thomas Petazzoni wrote:
> Register the irq controller driver in the main
> drivers/irqchip/irqchip.c file, and make sure that the initialization
> function of the driver sets handle_arch_irq() appropriately. This
> requires a bit of movement in the driver since the
> bcm2835_handle_irq() must move before the armctrl_of_init() function
> to avoid a forward declaration.
>
> On the arch/arm side, use irqchip_init() as the ->init_irq() callback,
> and remove the definition of ->handle_irq() since this is now done by
> the irq controller driver.
> diff --git a/drivers/irqchip/irq-bcm2835.c b/drivers/irqchip/irq-bcm2835.c
> +static void armctrl_handle_bank(int bank, struct pt_regs *regs)
To make the patch more readable, I'd suggest adding function prototypes
at the start of the file, and not re-arranging the code. That'll remove
the large cut/paste block in the diff. I wouldn't point out this trivial
issue except that I think this needs a respin for the minor issue I
raise below.
> -static int __init armctrl_of_init(struct device_node *node,
> - struct device_node *parent)
> +int __init armctrl_of_init(struct device_node *node,
> + struct device_node *parent)
Since this is now a public API, it should probably be named better. How
about bcm2835_irqchip_init()?
Aside from that,
Acked-by: Stephen Warren <swarren@wwwdotorg•org>
I don't foresee any likely conflicts with anything I'll stage for 3.8 in
the bcm2835 tree, so feel free to take this through the irq tree or
directly into arm-soc as appropriate.
next prev parent reply other threads:[~2012-10-28 2:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 16:45 [PATCH 1/3] irqchip: add basic infrastructure Thomas Petazzoni
2012-10-27 16:45 ` [PATCH 2/3] arm: bcm2835: convert to the irqchip infrastructure Thomas Petazzoni
2012-10-28 2:23 ` Stephen Warren [this message]
2012-10-28 9:03 ` Thomas Petazzoni
2012-10-27 16:45 ` [PATCH 3/3] arm: mvebu: move irq controller driver to drivers/irqchip Thomas Petazzoni
2012-10-28 2:25 ` Stephen Warren
2012-10-27 19:21 ` [PATCH 1/3] irqchip: add basic infrastructure Arnd Bergmann
2012-10-27 21:31 ` Thomas Gleixner
2012-10-28 8:58 ` Thomas Petazzoni
2012-10-28 2:20 ` Stephen Warren
2012-10-28 8:59 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508C970F.9000305@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox