From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] arm: bcm2835: properly use IOMEM() to define virtual address constants
Date: Mon, 29 Oct 2012 20:32:02 -0600 [thread overview]
Message-ID: <508F3C22.1000601@wwwdotorg.org> (raw)
In-Reply-To: <1351419853-25146-2-git-send-email-thomas.petazzoni@free-electrons.com>
On 10/28/2012 04:24 AM, Thomas Petazzoni wrote:
> Like we now do for all ARM platforms, use IOMEM() to define virtual
> address constants, so that they get typed as 'void __iomem *'
> pointers. It for now requires a cast when defining the map_desc entry,
> but that cast should disappear once we switch map_desc to the usage of
> 'void __iomem *' pointers.
> diff --git a/arch/arm/mach-bcm2835/bcm2835.c b/arch/arm/mach-bcm2835/bcm2835.c
> static struct map_desc io_map __initdata = {
> - .virtual = BCM2835_PERIPH_VIRT,
> + .virtual = (unsigned long) BCM2835_PERIPH_VIRT,
Very nit-picky, but there shouldn't be a space after the cast there.
next prev parent reply other threads:[~2012-10-30 2:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 10:24 [PATCH 1/2] arm: bcm2835: move to the multiplatform support Thomas Petazzoni
2012-10-28 10:24 ` [PATCH 2/2] arm: bcm2835: properly use IOMEM() to define virtual address constants Thomas Petazzoni
2012-10-30 2:32 ` Stephen Warren [this message]
2012-10-30 2:31 ` [PATCH 1/2] arm: bcm2835: move to the multiplatform support Stephen Warren
2012-10-30 8:20 ` Thomas Petazzoni
2012-10-30 16:53 ` Stephen Warren
2012-11-09 3:03 ` Stephen Warren
2012-11-09 8:05 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508F3C22.1000601@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox