From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] irqchip: Move ARM VIC to drivers/irqchip
Date: Tue, 30 Oct 2012 12:27:32 -0600 [thread overview]
Message-ID: <50901C14.5050605@wwwdotorg.org> (raw)
In-Reply-To: <1351608860-24617-3-git-send-email-robherring2@gmail.com>
On 10/30/2012 08:54 AM, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda•com>
>
> Now that we have drivers/irqchip, move VIC irqchip to drivers/irqchip.
> diff --git a/arch/arm/common/vic.c b/drivers/irqchip/irq-vic.c
> similarity index 100%
> rename from arch/arm/common/vic.c
> rename to drivers/irqchip/irq-vic.c
"gic" and "vic" seems a little generic for filenames and symbol names;
what about irq-arm-vic.c and irq-arm-gic.c? Similarly...
> diff --git a/drivers/irqchip/irqchip.h b/drivers/irqchip/irqchip.h
> int gic_of_init(struct device_node *node, struct device_node *parent);
> +int vic_of_init(struct device_node *node, struct device_node *parent);
... perhaps rename those to arm_[gv]ic_of_init()?
Are/will there be multiple versions of the GIC? I guess we can always
introduce a GIC2 later if needed, and leave the current one with an
unversioned name.
next prev parent reply other threads:[~2012-10-30 18:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 14:54 [PATCH 0/7] Move GIC and VIC to drivers/irqchip Rob Herring
2012-10-30 14:54 ` [PATCH 1/3] irqchip: Move ARM GIC " Rob Herring
2012-10-30 15:01 ` Thomas Petazzoni
2012-10-30 16:05 ` Rob Herring
2012-10-30 17:21 ` Rob Herring
2012-10-30 22:30 ` Thomas Petazzoni
2012-10-30 22:47 ` Russell King - ARM Linux
2012-10-31 0:04 ` Rob Herring
2012-10-31 9:05 ` Russell King - ARM Linux
2012-10-31 11:56 ` Catalin Marinas
2012-10-31 14:29 ` Rob Herring
2012-10-31 15:07 ` Russell King - ARM Linux
2012-10-30 14:54 ` [PATCH 2/3] irqchip: Move ARM VIC " Rob Herring
2012-10-30 18:27 ` Stephen Warren [this message]
2012-10-30 14:54 ` [PATCH 3/3] ARM: highbank: use common irqchip_init Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50901C14.5050605@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox