From: nsekhar@ti•com (Sekhar Nori)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 01/11] clk: davinci - add main PLL clock driver
Date: Wed, 31 Oct 2012 17:59:34 +0530 [thread overview]
Message-ID: <509119AE.6050505@ti.com> (raw)
In-Reply-To: <1351181518-11882-2-git-send-email-m-karicheri2@ti.com>
Hi Murali,
On 10/25/2012 9:41 PM, Murali Karicheri wrote:
> This is the driver for the main PLL clock hardware found on DM SoCs.
> This driver borrowed code from arch/arm/mach-davinci/clock.c and
> implemented the driver as per common clock provider API. The main PLL
> hardware typically has a multiplier, a pre-divider and a post-divider.
> Some of the SoCs has the divider fixed meaning they can not be
> configured through a register. HAS_PREDIV and HAS_POSTDIV flags are used
> to tell the driver if a hardware has these dividers present or not.
> Driver is configured through the struct clk_pll_data that has the
> SoC specific clock data.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti•com>
> ---
> diff --git a/drivers/clk/davinci/clk-pll.c b/drivers/clk/davinci/clk-pll.c
> +static unsigned long clk_pllclk_recalc(struct clk_hw *hw,
> + unsigned long parent_rate)
> +{
> + struct clk_pll *pll = to_clk_pll(hw);
> + struct clk_pll_data *pll_data = pll->pll_data;
> + u32 mult = 1, prediv = 1, postdiv = 1;
No need to initialize mult here. I gave this comment last time around as
well.
> + unsigned long rate = parent_rate;
> +
> + mult = readl(pll_data->reg_pllm);
> +
> + /*
> + * if fixed_multiplier is non zero, multiply pllm value by this
> + * value.
> + */
> + if (pll_data->fixed_multiplier)
> + mult = pll_data->fixed_multiplier *
> + (mult & pll_data->pllm_mask);
> + else
> + mult = (mult & pll_data->pllm_mask) + 1;
Hmm, this is interpreting the 'mult' register field differently in both
cases. In one case it is 'actual multiplier - 1' and in other case it is
the 'actual multiplier' itself. Can we be sure that the mult register
definition will change whenever there is a fixed multiplier in the PLL
block? I don't think any of the existing DaVinci devices have a fixed
multiplier. Is this on keystone?
> +struct clk *clk_register_davinci_pll(struct device *dev, const char *name,
> + const char *parent_name,
> + struct clk_pll_data *pll_data)
> +{
> + struct clk_init_data init;
> + struct clk_pll *pll;
> + struct clk *clk;
> +
> + if (!pll_data)
> + return ERR_PTR(-ENODEV);
-EINVAL? Clearly you are treating NULL value as an invalid argument here.
Thanks,
Sekhar
next prev parent reply other threads:[~2012-10-31 12:29 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 16:11 [PATCH v3 00/11] common clk drivers migration for DaVinci SoCs Murali Karicheri
2012-10-25 16:11 ` [PATCH v3 01/11] clk: davinci - add main PLL clock driver Murali Karicheri
2012-10-28 19:18 ` Linus Walleij
2012-10-31 13:23 ` Murali Karicheri
2012-10-31 12:29 ` Sekhar Nori [this message]
2012-10-31 13:46 ` Murali Karicheri
2012-11-01 11:01 ` Sekhar Nori
2012-10-25 16:11 ` [PATCH v3 02/11] clk: davinci - add PSC " Murali Karicheri
2012-10-28 19:24 ` Linus Walleij
2012-10-31 13:23 ` Murali Karicheri
2013-03-19 10:57 ` Sekhar Nori
2012-11-03 12:07 ` Sekhar Nori
2012-11-05 15:10 ` Murali Karicheri
2012-11-10 2:22 ` Mike Turquette
2012-11-27 15:05 ` Sekhar Nori
2012-11-27 17:29 ` Mike Turquette
2012-11-27 20:38 ` Murali Karicheri
2012-11-28 13:22 ` Sekhar Nori
2013-03-22 11:20 ` Sekhar Nori
2013-03-22 20:37 ` Mike Turquette
2013-03-25 6:50 ` Sekhar Nori
2012-10-25 16:11 ` [PATCH v3 03/11] clk: davinci - common clk utilities to init clk driver Murali Karicheri
2012-10-28 19:25 ` Linus Walleij
2012-10-31 13:23 ` Murali Karicheri
2012-11-01 12:41 ` Sekhar Nori
2012-11-01 18:34 ` Murali Karicheri
2012-11-03 12:35 ` Sekhar Nori
2012-11-05 15:20 ` Murali Karicheri
2012-11-06 9:31 ` Sekhar Nori
2012-11-06 15:04 ` Murali Karicheri
2012-10-25 16:11 ` [PATCH v3 04/11] clk: davinci - add pll divider clock driver Murali Karicheri
2012-10-28 19:26 ` Linus Walleij
2012-10-31 13:22 ` Murali Karicheri
2012-11-02 11:33 ` Sekhar Nori
2012-11-02 13:53 ` Murali Karicheri
2012-11-03 12:03 ` Sekhar Nori
2012-11-05 15:10 ` Murali Karicheri
2012-10-25 16:11 ` [PATCH v3 05/11] clk: davinci - add dm644x clock initialization Murali Karicheri
2012-11-03 13:30 ` Sekhar Nori
2012-11-05 15:42 ` Murali Karicheri
2012-11-06 10:18 ` Sekhar Nori
2012-11-05 23:23 ` Murali Karicheri
2012-11-06 9:40 ` Sekhar Nori
2012-10-25 16:11 ` [PATCH v3 06/11] clk: davinci - add build infrastructure for DaVinci clock drivers Murali Karicheri
2012-11-04 13:34 ` Sekhar Nori
2012-11-05 16:17 ` Murali Karicheri
2012-11-06 9:48 ` Sekhar Nori
2012-10-25 16:11 ` [PATCH v3 07/11] ARM: davinci - restructure header files for common clock migration Murali Karicheri
2012-11-04 14:05 ` Sekhar Nori
2012-11-05 19:11 ` Murali Karicheri
2012-11-06 10:03 ` Sekhar Nori
2012-11-05 21:57 ` Murali Karicheri
2012-12-03 13:23 ` Sekhar Nori
2012-10-25 16:11 ` [PATCH v3 08/11] ARM: davinci - migrating to use common clock init code Murali Karicheri
2012-10-25 16:11 ` [PATCH v3 09/11] ARM: davinci - dm644x: update SoC code to remove the clock data Murali Karicheri
2012-10-25 16:11 ` [PATCH v3 10/11] ARM: davinci - migrate to common clock Murali Karicheri
2012-11-04 13:06 ` Sekhar Nori
2012-11-05 15:43 ` Murali Karicheri
2012-10-25 16:11 ` [PATCH v3 11/11] ARM: davinci - common clock migration: clean up the old code Murali Karicheri
2012-10-30 17:00 ` [PATCH v3 00/11] common clk drivers migration for DaVinci SoCs Karicheri, Muralidharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509119AE.6050505@ti.com \
--to=nsekhar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox