From: b-cousson@ti•com (Benoit Cousson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle
Date: Mon, 5 Nov 2012 17:59:36 +0100 [thread overview]
Message-ID: <5097F078.50701@ti.com> (raw)
In-Reply-To: <1352108549-9341-2-git-send-email-anilkumar@ti.com>
+ Mark
On 11/05/2012 10:42 AM, AnilKumar Ch wrote:
> From: Colin Foe-Parker <colin.foeparker@logicpd•com>
>
> Set tps65217 PMIC status to OFF if power enable toggle is
> supported. Also adds platform data flag, which should be
> passed from board init data.
>
> Signed-off-by: Colin Foe-Parker <colin.foeparker@logicpd•com>
> [anilkumar at ti.com: move the additions to tps65217 MFD driver]
> Signed-off-by: AnilKumar Ch <anilkumar@ti•com>
> ---
> .../devicetree/bindings/regulator/tps65217.txt | 4 ++++
> drivers/mfd/tps65217.c | 12 ++++++++++++
> 2 files changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/regulator/tps65217.txt b/Documentation/devicetree/bindings/regulator/tps65217.txt
> index d316fb8..4f05d20 100644
> --- a/Documentation/devicetree/bindings/regulator/tps65217.txt
> +++ b/Documentation/devicetree/bindings/regulator/tps65217.txt
> @@ -11,6 +11,9 @@ Required properties:
> using the standard binding for regulators found at
> Documentation/devicetree/bindings/regulator/regulator.txt.
>
> +Optional properties:
> +- ti,pmic-shutdown-controller: Telling the PMIC to shutdown on PWR_EN toggle.
That sounds like a generic functionality to me. Don't we have some more
generic way to handle that?
If not, that should probably not be a TI only attribute.
It looks like a GPIO like kind of interface at PMIC level.
Regards,
Benoit
> +
> The valid names for regulators are:
> tps65217: dcdc1, dcdc2, dcdc3, ldo1, ldo2, ldo3 and ldo4
>
> @@ -20,6 +23,7 @@ Example:
>
> tps: tps at 24 {
> compatible = "ti,tps65217";
> + ti,pmic-shutdown-controller;
>
> regulators {
> dcdc1_reg: dcdc1 {
> diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c
> index 3fb32e6..c7f17d8 100644
> --- a/drivers/mfd/tps65217.c
> +++ b/drivers/mfd/tps65217.c
> @@ -160,6 +160,7 @@ static int __devinit tps65217_probe(struct i2c_client *client,
> unsigned int version;
> unsigned int chip_id = ids->driver_data;
> const struct of_device_id *match;
> + bool status_off = false;
> int ret;
>
> if (client->dev.of_node) {
> @@ -170,6 +171,8 @@ static int __devinit tps65217_probe(struct i2c_client *client,
> return -EINVAL;
> }
> chip_id = (unsigned int)match->data;
> + status_off = of_property_read_bool(client->dev.of_node,
> + "ti,pmic-shutdown-controller");
> }
>
> if (!chip_id) {
> @@ -207,6 +210,15 @@ static int __devinit tps65217_probe(struct i2c_client *client,
> return ret;
> }
>
> + /* Set the PMIC to shutdown on PWR_EN toggle */
> + if (status_off) {
> + ret = tps65217_set_bits(tps, TPS65217_REG_STATUS,
> + TPS65217_STATUS_OFF, TPS65217_STATUS_OFF,
> + TPS65217_PROTECT_NONE);
> + if (ret)
> + dev_warn(tps->dev, "unable to set the status OFF\n");
> + }
> +
> dev_info(tps->dev, "TPS65217 ID %#x version 1.%d\n",
> (version & TPS65217_CHIPID_CHIP_MASK) >> 4,
> version & TPS65217_CHIPID_REV_MASK);
>
next prev parent reply other threads:[~2012-11-05 16:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 9:42 [PATCH 0/4] pm: Add power off control AnilKumar Ch
2012-11-05 9:42 ` [PATCH 1/4] mfd: tps65217: Set PMIC to shutdowm on PWR_EN toggle AnilKumar Ch
2012-11-05 16:59 ` Benoit Cousson [this message]
2012-11-06 5:13 ` AnilKumar, Chimata
2012-11-14 2:23 ` Mark Brown
2012-11-14 5:10 ` AnilKumar, Chimata
2012-11-14 6:11 ` AnilKumar, Chimata
2012-11-14 6:21 ` Mark Brown
2012-11-14 6:49 ` AnilKumar, Chimata
2012-11-14 7:00 ` Mark Brown
2012-11-14 10:08 ` Benoit Cousson
2012-11-14 10:24 ` Mark Brown
2012-11-16 6:16 ` AnilKumar, Chimata
2012-11-05 9:42 ` [PATCH 2/4] rtc: OMAP: Add system pm_power_off to rtc driver AnilKumar Ch
2012-11-05 16:43 ` Benoit Cousson
2012-11-05 17:39 ` Colin FoeParker
2012-11-06 5:07 ` AnilKumar, Chimata
2012-11-06 16:56 ` Benoit Cousson
2012-11-12 9:47 ` AnilKumar, Chimata
2012-11-14 5:01 ` AnilKumar, Chimata
2012-11-14 5:21 ` Mark Brown
2012-11-14 5:50 ` AnilKumar, Chimata
2012-11-14 6:00 ` Mark Brown
2012-11-06 5:45 ` Bedia, Vaibhav
2012-11-12 9:47 ` AnilKumar, Chimata
2012-11-16 6:13 ` AnilKumar, Chimata
2012-11-16 10:47 ` AnilKumar, Chimata
2012-11-05 9:42 ` [PATCH 3/4] ARM: dts: AM33XX: Set pmic-shutdown-controller for BeagleBone AnilKumar Ch
2012-11-05 9:42 ` [PATCH 4/4] ARM: dts: AM33XX: Enable system power off control in am335x-bone AnilKumar Ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5097F078.50701@ti.com \
--to=b-cousson@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox