public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons•com (Maxime Ripard)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: mxs: apf28dev: Add I2C, SPI and spidev support
Date: Wed, 07 Nov 2012 10:07:32 +0100	[thread overview]
Message-ID: <509A24D4.9000308@free-electrons.com> (raw)
In-Reply-To: <1352225793-93208-1-git-send-email-gwenhael.goavec-merou@armadeus.com>

Le 06/11/2012 19:16, Gwenhael Goavec-Merou a ?crit :
> 
> Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@armadeus•com>
> ---
>  arch/arm/boot/dts/imx28-apf28dev.dts |   19 +++++++++++++++++++
>  1 files changed, 19 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx28-apf28dev.dts b/arch/arm/boot/dts/imx28-apf28dev.dts
> index 1643d25..da7013d 100644
> --- a/arch/arm/boot/dts/imx28-apf28dev.dts
> +++ b/arch/arm/boot/dts/imx28-apf28dev.dts
> @@ -27,6 +27,19 @@
>  				status = "okay";
>  			};
>  
> +			ssp2: ssp at 80014000 {
> +				compatible = "fsl,imx28-spi";
> +				pinctrl-names = "default";
> +				pinctrl-0 = <&spi2_pins_a>;
> +				status = "okay";
> +
> +				spidev: spidev at 0 {
> +					compatible = "spidev";
> +					spi-max-frequency = <40000000>;
> +					reg = <0>;
> +				};
> +			};

This won't work, since the compatible string is not matching in the
spidev driver.

You need to add the compatible string of the spi device that you will
drive with spidev in the spidev driver, and then use this string in your
dts.

See
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-October/129134.html
and
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-October/129133.html


-- 
Maxime Ripard, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-11-07  9:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06 18:16 [PATCH] ARM: mxs: apf28dev: Add I2C, SPI and spidev support Gwenhael Goavec-Merou
2012-11-07  9:07 ` Maxime Ripard [this message]
2012-11-07 14:20   ` gwenhael.goavec
2012-11-07 14:22     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509A24D4.9000308@free-electrons.com \
    --to=maxime.ripard@free-electrons$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox