From: jon-hunter@ti•com (Jon Hunter)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 01/14] ARM: OMAP: Add DMTIMER definitions for posted mode
Date: Wed, 7 Nov 2012 16:11:37 -0600 [thread overview]
Message-ID: <509ADC99.3020106@ti.com> (raw)
In-Reply-To: <509ADAFE.4070109@ti.com>
On 11/07/2012 04:04 PM, Santosh Shilimkar wrote:
> On Wednesday 07 November 2012 01:01 PM, Jon Hunter wrote:
>> For OMAP2+ devices, when using DMTIMERs for system timers
>> (clock-events and
>> clock-source) the posted mode configuration of the timers is used. To
>> allow
>> the compiler to optimise the functions for configuring and reading the
>> system
>> timers, the posted flag variable is hard-coded with the value 1. To
>> make it
>> clear that posted mode is being used add some definitions so that it
>> is more
>> readable.
>>
>> Add separate definitions for the clock-events and clock-source timers
>> so that
>> we can change the posted mode of clock-events and clock-source
>> independently.
>>
>> Signed-off-by: Jon Hunter <jon-hunter@ti•com>
>> ---
>> arch/arm/mach-omap2/timer.c | 26
>> +++++++++++++++++++-------
>> arch/arm/plat-omap/include/plat/dmtimer.h | 4 ++++
>> 2 files changed, 23 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
>> index 0758bae..28c6078 100644
>> --- a/arch/arm/mach-omap2/timer.c
>> +++ b/arch/arm/mach-omap2/timer.c
>> @@ -82,6 +82,13 @@
>> #define INCREMENTER_DENUMERATOR_RELOAD_OFFSET 0x14
>> #define NUMERATOR_DENUMERATOR_MASK 0xfffff000
>>
>> +/*
>> + * For clock-events timer, always use posted mode to
>> + * minimise CPU overhead for configuring the timer.
>> + */
>> +#define OMAP_CLKEVT_POSTEDMODE OMAP_TIMER_POSTED
>> +#define OMAP_CLKSRC_POSTEDMODE OMAP_TIMER_POSTED
>> +
> I don't see need of above defines. Just use OMAP_TIMER_POSTED directly
> with API. Rest of the patch looks fine.
Yes that's possible, however, in patch #2, I am disabling posted mode
for clock-source (see changelog of patch #2 for details). Having these
#defines makes it easier to change the posted configuration. That was
the real motivation here.
Cheers
Jon
next prev parent reply other threads:[~2012-11-07 22:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 19:01 [PATCH V2 00/14] ARM: OMAP: DMTIMER fixes Jon Hunter
2012-11-07 19:01 ` [PATCH V2 01/14] ARM: OMAP: Add DMTIMER definitions for posted mode Jon Hunter
2012-11-07 22:04 ` Santosh Shilimkar
2012-11-07 22:11 ` Jon Hunter [this message]
2012-11-07 22:18 ` Santosh Shilimkar
2012-11-07 22:47 ` Jon Hunter
2012-11-08 16:52 ` Jon Hunter
2012-11-07 19:01 ` [PATCH V2 02/14] ARM: OMAP2+: Disable posted mode for the clocksource timer Jon Hunter
2012-11-07 22:10 ` Santosh Shilimkar
2012-11-07 22:41 ` Jon Hunter
2012-11-07 19:01 ` [PATCH V2 03/14] ARM: OMAP3+: Implement timer workaround for errata i103 and i767 Jon Hunter
2012-11-07 22:14 ` Santosh Shilimkar
2012-11-07 23:28 ` Jon Hunter
2012-11-07 23:43 ` Santosh Shilimkar
2012-11-08 16:55 ` Jon Hunter
2012-11-09 19:41 ` Jon Hunter
2012-11-07 19:01 ` [PATCH V2 04/14] ARM: OMAP: Fix timer posted mode support Jon Hunter
2012-11-07 22:21 ` Santosh Shilimkar
2012-11-07 19:01 ` [PATCH V2 05/14] ARM: OMAP3: Correct HWMOD DMTIMER SYSC register declarations Jon Hunter
2012-11-07 19:01 ` [PATCH V2 06/14] ARM: OMAP2/3: Define HWMOD software reset status for DMTIMERs Jon Hunter
2012-11-07 19:01 ` [PATCH V2 07/14] ARM: OMAP2+: Don't use __omap_dm_timer_reset() Jon Hunter
2012-11-07 19:01 ` [PATCH V2 08/14] ARM: OMAP: Fix dmtimer reset for timer1 Jon Hunter
2012-11-07 19:01 ` [PATCH V2 09/14] ARM: OMAP: Don't restore of DMTIMER TISTAT register Jon Hunter
2012-11-07 19:01 ` [PATCH V2 10/14] ARM: OMAP: Don't restore DMTIMER interrupt status register Jon Hunter
2012-11-07 19:01 ` [PATCH V2 11/14] ARM: OMAP: Fix spurious interrupts when using timer match feature Jon Hunter
2012-11-07 19:01 ` [PATCH V2 12/14] ARM: OMAP: Add dmtimer interrupt disable function Jon Hunter
2012-11-07 19:01 ` [PATCH V2 13/14] ARM: OMAP: Remove unnecessary call to clk_get() Jon Hunter
2012-11-07 19:01 ` [PATCH V2 14/14] ARM: OMAP: Remove __omap_dm_timer_set_source function Jon Hunter
2012-11-07 21:22 ` [PATCH V2 00/14] ARM: OMAP: DMTIMER fixes Tony Lindgren
2012-11-07 21:44 ` Jon Hunter
2012-11-07 21:52 ` Tony Lindgren
2012-11-07 22:27 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509ADC99.3020106@ti.com \
--to=jon-hunter@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox