From: sylvester.nawrocki@gmail•com (Sylwester Nawrocki)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: S3C64XX: Statically define parent clock of the "camera" clock
Date: Fri, 09 Nov 2012 11:05:40 +0100 [thread overview]
Message-ID: <509CD574.2050909@gmail.com> (raw)
In-Reply-To: <CAA11ShABPJhLP5dvx65=HOzSNoiY+jjiiNPAvd_x_5z7K3meVg@mail.gmail.com>
Hi,
On 11/09/2012 10:31 AM, Andrey Gusakov wrote:
> On Fri, Nov 9, 2012 at 12:32 PM, Sylwester Nawrocki
> <sylvester.nawrocki@gmail•com> wrote:
>> The "camera" clock defined in arch/arm/mach-s3c64xx/clock.c has null
>> clock source mux control register as it can have only one parent
>> clock. In such cases there is a need to configure the parent clock
>> statically, otherwise s3c_set_clksrc() bails out with an error message
>> "no parent clock specified" leaving the parent clock not configured.
>> Define statically the parent clock so it is possible to get or set
>> rate of the "camera" clock.
>> While at it remove the unneded null reg_src definition.
>>
>> Reported-by: In-Bae Jeong<kukyakya@gmail•com>
>> Signed-off-by: Sylwester Nawrocki<sylvester.nawrocki@gmail•com>
>> ---
>> arch/arm/mach-s3c64xx/clock.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach-s3c64xx/clock.c
>> index 28041e8..2e6d7f9 100644
>> --- a/arch/arm/mach-s3c64xx/clock.c
>> +++ b/arch/arm/mach-s3c64xx/clock.c
>> @@ -744,9 +744,9 @@ static struct clksrc_clk clksrcs[] = {
>> .name = "camera",
>> .ctrlbit = S3C_CLKCON_SCLK_CAM,
>> .enable = s3c64xx_sclk_ctrl,
>> + .parent =&clk_h2,
>> },
>> .reg_div = { .reg = S3C_CLK_DIV0, .shift = 20, .size = 4 },
>> - .reg_src = { .reg = NULL, .shift = 0, .size = 0 },
>> .sources =&clkset_camif,
> Just figure out that .sources can be removed to. And seems
> "clkset_camif" and "clkset_camif_list" can be removed as unused.
OK, you're right. I think it could be done as a separate patch,
depending on this one to avoid conflicts.
> I'll try to test it tiday.
Thanks.
next prev parent reply other threads:[~2012-11-09 10:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 22:00 [PATCH 1/2] ARM: S3C24XX: Add clkdev entry for camif-upll clock Sylwester Nawrocki
2012-11-07 22:00 ` [PATCH 2/2] ARM: S3C64XX: Statically define parent clock of the "camera" clock Sylwester Nawrocki
2012-11-09 7:42 ` Andrey Gusakov
2012-11-09 8:30 ` Sylwester Nawrocki
2012-11-09 8:32 ` [PATCH] " Sylwester Nawrocki
2012-11-09 9:31 ` Andrey Gusakov
2012-11-09 10:05 ` Sylwester Nawrocki [this message]
2012-11-09 10:18 ` Sylwester Nawrocki
2012-11-09 10:08 ` Kukjin Kim
2012-11-22 6:51 ` [PATCH 1/2] ARM: S3C24XX: Add clkdev entry for camif-upll clock Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509CD574.2050909@gmail.com \
--to=sylvester.nawrocki@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox