From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: tegra: retain L2 content over CPU suspend/resume
Date: Mon, 12 Nov 2012 09:36:15 -0700 [thread overview]
Message-ID: <50A1257F.8090003@wwwdotorg.org> (raw)
In-Reply-To: <1352693437.19251.9.camel@jlo-ubuntu-64.nvidia.com>
On 11/11/2012 09:10 PM, Joseph Lo wrote:
> On Sat, 2012-11-10 at 05:54 +0800, Stephen Warren wrote:
>> On 11/06/2012 02:32 AM, Joseph Lo wrote:
>>> The L2 RAM is in different power domain from the CPU cluster. So the
>>> L2 content can be retained over CPU suspend/resume. To do that, we
>>> need to disable L2 after the MMU is disabled, and enable L2 before
>>> the MMU is enabled. But the L2 controller is in the same power domain
>>> with the CPU cluster. We need to restore it's settings and re-enable
>>> it after the power be resumed.
>>
>> This doesn't compile:
>>
>> arch/arm/mach-tegra/headsmp.S: Assembler messages:
>> arch/arm/mach-tegra/headsmp.S:119: Error: undefined symbol L2X0_CTRL_EN
>> used as an immediate value
>> arch/arm/mach-tegra/headsmp.S:119: Error: undefined symbol L2X0_CTRL_EN
>> used as an immediate value
>
> Ah, sorry for mention that.
> This patch was depended on "07bd005 ARM: 7547/1: cache-l2x0: add support
> for Aurora L2 cache ctrl" and only showed up after "next-20121024". The
> definition of "L2X0_CTRL_EN" was been introduced in that patch.
>
> Should I re-send a patch that based on tegra "for-next" branch that will
> change L2X0_CTRL_EN to 0x1? Sorry for inconvenience.
That's probably simplest. Perhaps rather than just replacing the #define
with a literal, do:
#ifndef L2X0_CTRL_EN
#define L2X0_CTRL_EN 1
#endif
So that we can simply remove that ifdef block later once we know patch
7547 is present.
next prev parent reply other threads:[~2012-11-12 16:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 9:32 [PATCH] ARM: tegra: retain L2 content over CPU suspend/resume Joseph Lo
2012-11-09 21:54 ` Stephen Warren
2012-11-12 4:10 ` Joseph Lo
2012-11-12 16:36 ` Stephen Warren [this message]
2012-11-12 12:39 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A1257F.8090003@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox