From: sshtylyov@mvista•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 2/6] ARM: davinci: Changed pr_warning() to pr_warn() (part 2)
Date: Wed, 14 Nov 2012 14:17:13 +0400 [thread overview]
Message-ID: <50A36FA9.5050601@mvista.com> (raw)
In-Reply-To: <1352853207-20602-2-git-send-email-rtivy@ti.com>
Hello.
On 14-11-2012 4:33, Robert Tivy wrote:
> Also, while modifying those pr_warning() calls I changed hardcoded
> function names to use '"%s:", __func__' instead
> Signed-off-by: Robert Tivy <rtivy@ti•com>
> ---
> Clean up files that will be otherwise modified in subsequent patch.
> Applies to v3.7-rc2 tag (commit 6f0c0580b70c89094b3422ba81118c7b959c7556) of
> Linus' mainline kernel at git.kernel.org.
> arch/arm/mach-davinci/board-omapl138-hawk.c | 30 ++++++++++-----------------
> 1 file changed, 11 insertions(+), 19 deletions(-)
Taksing of separation of board and SoC specific changes, this patch
shouldn't have been separated from patch 1 at all -- since it's two boards
built around the same chip, OMAP-L138...
> diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c
> index dc1208e..8aea169 100644
> --- a/arch/arm/mach-davinci/board-omapl138-hawk.c
> +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
> @@ -48,8 +48,7 @@ static __init void omapl138_hawk_config_emac(void)
> val &= ~BIT(8);
> ret = davinci_cfg_reg_list(omapl138_hawk_mii_pins);
> if (ret) {
> - pr_warning("%s: cpgmac/mii mux setup failed: %d\n",
> - __func__, ret);
> + pr_warn("%s: cpgmac/mii mux setup failed: %d\n", __func__, ret);
I'd have preferred this as "CPGMAC/MII". Almost all other acronyms in the
messages are capitalized.
> return;
> }
>
> @@ -61,8 +60,7 @@ static __init void omapl138_hawk_config_emac(void)
>
> ret = da8xx_register_emac();
> if (ret)
> - pr_warning("%s: emac registration failed: %d\n",
> - __func__, ret);
> + pr_warn("%s: emac registration failed: %d\n", __func__, ret);
... and "EMAC" here.
WBR, Sergei
next prev parent reply other threads:[~2012-11-14 10:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1352853207-20602-1-git-send-email-rtivy@ti.com>
2012-11-14 10:12 ` [PATCH v3 1/6] ARM: davinci: Changed pr_warning() to pr_warn() (part 1) Sergei Shtylyov
[not found] ` <1352853207-20602-2-git-send-email-rtivy@ti.com>
2012-11-14 10:17 ` Sergei Shtylyov [this message]
2012-11-15 1:53 ` [PATCH v3 2/6] ARM: davinci: Changed pr_warning() to pr_warn() (part 2) Tivy, Robert
2012-11-15 9:46 ` Sergei Shtylyov
2012-11-20 11:27 ` Sekhar Nori
[not found] ` <1352853207-20602-5-git-send-email-rtivy@ti.com>
2012-11-20 12:26 ` [PATCH v3 5/6] ARM: davinci: remoteproc board support for OMAP-L138 DSP Sekhar Nori
2012-11-29 1:38 ` Tivy, Robert
2012-11-30 10:50 ` Sekhar Nori
2012-12-01 2:11 ` Tivy, Robert
2012-12-03 14:41 ` Sekhar Nori
2012-12-03 20:13 ` Cyril Chemparathy
2012-12-04 2:30 ` Tivy, Robert
2012-12-04 5:58 ` Sekhar Nori
[not found] ` <50BE0E54.5060607@ti.com>
[not found] ` <50BE2115.4000606@ti.com>
[not found] ` <13514BD7FAEBA745BBD7D8A672905C14311FB29D@DFLE08.ent.ti.com>
2012-12-05 8:35 ` Sekhar Nori
2012-12-07 8:24 ` Sekhar Nori
2012-12-08 1:04 ` Tivy, Robert
2012-12-12 1:36 ` Tivy, Robert
2012-12-12 10:34 ` Sekhar Nori
2012-12-12 11:01 ` Prabhakar Lad
2012-12-12 13:06 ` Sekhar Nori
2012-12-12 13:13 ` Prabhakar Lad
2012-12-13 8:18 ` Prabhakar Lad
2012-12-14 8:17 ` Sekhar Nori
2012-12-14 2:19 ` Tivy, Robert
[not found] ` <1352853207-20602-6-git-send-email-rtivy@ti.com>
2012-11-20 12:30 ` [PATCH v3 6/6] ARM: davinci: remoteproc driver " Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A36FA9.5050601@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox