From: voice.shen@atmel•com (Bo Shen)
To: linux-arm-kernel@lists•infradead.org
Subject: [Resend v6 PATCH 2/2] ASoC: atmel-ssc: add pinctrl consumer
Date: Fri, 16 Nov 2012 14:59:25 +0800 [thread overview]
Message-ID: <50A5E44D.6040501@atmel.com> (raw)
In-Reply-To: <20121116064113.GQ4387@opensource.wolfsonmicro.com>
On 11/16/2012 14:41, Mark Brown wrote:
> On Fri, Nov 16, 2012 at 02:33:50PM +0800, Bo Shen wrote:
>> On 11/16/2012 14:12, Mark Brown wrote:
>
>>> No, this isn't what was meant - the idea is to send only the addition of
>>> pinctrl data as one patch, based off the ASoC branch instead of -next.
>
>> What is the pinctrl data? (This patch can be applied on
>
> The data you're adding in the device tree!
>
>> sound/topic/atmel branch without any conflicts)
>
> That's not helpful to anyone doing bisection if there's nothing defining
> the pin states, it means that the system won't be able to start the
> driver as the API call will fail.
>
>> The other one add pinctrl nodes, must based on -next, or else I
>> don't know where should I add the pinctrl nodes.
>
> What makes you say this?
For example, if I want to add pinctrl node
---<8---
ssc0 {
pinctrl_ssc0_tx: ssc0_tx-0 {
atmel,pins = <1 16 0x1 0x0 /* PB16 periph A */
1 17 0x1 0x0 /* PB17 periph A */
1 18 0x1 0x0>; /* PB18 periph A */
};
--->8---
This should be add into dtsi file as following
---<8---
ahb {
apb {
pinctrl {
ssc0 {
pinctrl_ssc0_tx
}
}
}
}
--->8---
In the ASoC branch tree, I don't see any pinctrl related information.
So, I say I don't know where should I add the pinctrl nodes.
May be I misunderstanding, do you mean I should only add as followign
based on ASoC tree? And the upper go into pinctrl tree?
---<8---
ssc0: ssc@fffbc000 {
compatible = "atmel,at91rm9200-ssc";
reg = <0xfffbc000 0x4000>;
interrupts = <14 4 5>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ssc0_tx &pinctrl_ssc0_rx>;
status = "disable";
};
--->8---
Best Regards
Bo Shen
next prev parent reply other threads:[~2012-11-16 6:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 6:03 [Resend v6 PATCH 1/2] ARM: at91: atmel-ssc: add pinctrl nodes Bo Shen
2012-11-16 6:03 ` [Resend v6 PATCH 2/2] ASoC: atmel-ssc: add pinctrl consumer Bo Shen
2012-11-16 6:12 ` Mark Brown
2012-11-16 6:33 ` Bo Shen
2012-11-16 6:41 ` Mark Brown
2012-11-16 6:59 ` Bo Shen [this message]
2012-11-20 9:31 ` Bo Shen
2012-11-20 10:27 ` Mark Brown
2012-11-21 1:43 ` Bo Shen
2012-11-21 1:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A5E44D.6040501@atmel.com \
--to=voice.shen@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox