From: gregory.clement@free-electrons•com (Gregory CLEMENT)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V3 1/3] arm: dma mapping: Export dma ops functions
Date: Wed, 21 Nov 2012 09:17:26 +0100 [thread overview]
Message-ID: <50AC8E16.3020006@free-electrons.com> (raw)
In-Reply-To: <50AC8D09.6050104@samsung.com>
On 11/21/2012 09:12 AM, Marek Szyprowski wrote:
> Hello,
>
> On 11/21/2012 9:05 AM, Gregory CLEMENT wrote:
>> On 11/21/2012 08:06 AM, Marek Szyprowski wrote:
>>> On 11/20/2012 10:56 PM, Gregory CLEMENT wrote:
>>>> Expose the DMA operations functions. Until now only the dma_ops
>>>> structs in a whole or some dma operation were exposed. This patch
>>>> exposes all the dma coherents operations. They can be reused when an
>>>> architecture or a driver need to create its own set of dma_operation.
>>>>
>>>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons•com>
>>>
>>> Besides arm_dma_set_mask() function I see no reason to export the other
>>> arm dma related functions.
>>
>> The idea was to let other people use the arm dma related functions,
>> for their own dma ops. But for the mvebu machines we only need
>> arm_dma_set_mask() indeed.
>>
>> So you prefer that I only expose arm_dma_set_mask() and let future
>> user expose other function if they need it, right?
>
> I would prefer to avoid exporting functions which are not used anywhere
> else. This improves readability of the code and simply forces others to
> think twice before they use some static function and check if their use
> case is really correct.
OK so I will send a new version in a few minutes.
Do you think these last changes will be enough for getting your Acked-by?
Thanks,
Greogry
next prev parent reply other threads:[~2012-11-21 8:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 21:56 [PATCH V3 0/3] Add hardware I/O coherency support for Armada 370/XP Gregory CLEMENT
2012-11-20 21:56 ` [PATCH V3 1/3] arm: dma mapping: Export dma ops functions Gregory CLEMENT
2012-11-21 7:06 ` Marek Szyprowski
2012-11-21 8:05 ` Gregory CLEMENT
2012-11-21 8:12 ` Marek Szyprowski
2012-11-21 8:17 ` Gregory CLEMENT [this message]
2012-11-21 8:35 ` Marek Szyprowski
2012-11-20 21:56 ` [PATCH V3 2/3] arm: plat-orion: Add coherency attribute when setup mbus target Gregory CLEMENT
2012-11-20 21:56 ` [PATCH V3 3/3] arm: mvebu: Add hardware I/O Coherency support Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AC8E16.3020006@free-electrons.com \
--to=gregory.clement@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox