From: archit@ti•com (Archit Taneja)
To: linux-arm-kernel@lists•infradead.org
Subject: OMAP4430 produces boot warnings
Date: Mon, 26 Nov 2012 12:18:51 +0530 [thread overview]
Message-ID: <50B310D3.9050202@ti.com> (raw)
In-Reply-To: <1353663278.25248.4.camel@sokoban>
On Friday 23 November 2012 03:04 PM, Tero Kristo wrote:
> On Thu, 2012-11-22 at 16:44 +0200, Tomi Valkeinen wrote:
>> On 2012-11-22 16:34, Tero Kristo wrote:
>>
>>> I guess you checked that DSS pwrdm is switching between RET and ON in
>>> your setup?
>>
>> Yes:
>>
>> # cat /debug/pm_debug/count |grep dss
>> [ 35.356567] pwrdm state mismatch(l3init_pwrdm) 3 != 1
>> [ 35.361938] pwrdm state mismatch(cam_pwrdm) 3 != 0
>> [ 35.366973] pwrdm state mismatch(ivahd_pwrdm) 3 != 1
>> [ 35.372253] pwrdm state mismatch(tesla_pwrdm) 3 != 1
>> [ 35.377532] pwrdm state mismatch(abe_pwrdm) 3 != 1
>> dss_pwrdm (RET),OFF:1,RET:11,INA:0,ON:11,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0
>> l3_dss_clkdm->dss_pwrdm (0)
>>
>> then I load and unload the dss modules, and then:
>>
>> # cat /debug/pm_debug/count |grep dss
>> [ 60.813629] pwrdm state mismatch(l3init_pwrdm) 3 != 1
>> [ 60.819000] pwrdm state mismatch(cam_pwrdm) 3 != 0
>> [ 60.824127] pwrdm state mismatch(ivahd_pwrdm) 3 != 1
>> [ 60.829376] pwrdm state mismatch(tesla_pwrdm) 3 != 1
>> [ 60.834625] pwrdm state mismatch(abe_pwrdm) 3 != 1
>> dss_pwrdm (ON),OFF:1,RET:21,INA:0,ON:22,RET-LOGIC-OFF:0,RET-MEMBANK1-OFF:0
>> l3_dss_clkdm->dss_pwrdm (0)
>>
>>>> Does the pwrdm mistakenly think that in RET state the DSS still keeps
>>>> the register contents?
>>>
>>> This might be the case, however the pwrdm code should be generic and
>>> handle all domains properly. What is the tree / branch / commit you are
>>> using for testing this stuff? I can take a look at this also.
>>
>> arm-soc/for-next
>
> I guess this is caused because some of the patches are still not in the
> for-next branch, it looks like at least this is missing:
>
> https://patchwork.kernel.org/patch/1608901/
>
> ...or the latest update done by Paul to that one.
>
> The patch I posted appears to have a small merge induced bug, it is
> registering the context loss soc_ops for am33xx when it should actually
> register those for omap4. This might explain another bug I've been
> looking at in a different branch recently... The update Paul posted does
> not seem to have this problem, but I haven't tested it myself.
Applying the patch above, and registering the soc_ops for omap4 instead
of am33xx doesn't seem to help. The context lost count now always returns 0.
And to verify Tomi's observation, if we don't rely on the context lost
count, and restore the registers always, we don't see the problem.
Btw, we use the function omap_pm_get_dev_context_loss_count to get the
count, do we use this or is there a new func to get the count?
Thanks,
Archit
next prev parent reply other threads:[~2012-11-26 6:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 23:03 OMAP4430 produces boot warnings Russell King - ARM Linux
2012-11-22 12:42 ` Archit Taneja
2012-11-22 13:42 ` Tomi Valkeinen
2012-11-22 14:34 ` Tero Kristo
2012-11-22 14:44 ` Tomi Valkeinen
2012-11-23 9:34 ` Tero Kristo
2012-11-26 6:48 ` Archit Taneja [this message]
2012-11-26 12:14 ` Archit Taneja
2012-11-27 11:23 ` Tomi Valkeinen
2012-11-27 11:56 ` Archit Taneja
2012-11-27 12:21 ` Tomi Valkeinen
2012-11-27 12:31 ` Tero Kristo
2012-11-28 10:44 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B310D3.9050202@ti.com \
--to=archit@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox