From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] mfd: vexpress-sysreg: Remove LEDs code
Date: Tue, 27 Nov 2012 11:00:18 -0700 [thread overview]
Message-ID: <50B4FFB2.6050601@wwwdotorg.org> (raw)
In-Reply-To: <CAOesGMgJqPCXNxfEA+=NVE_yMtSKS_vnzNkT9Of9bqw0t5iMww@mail.gmail.com>
On 11/21/2012 02:04 AM, Olof Johansson wrote:
> On Wed, Nov 21, 2012 at 12:55 AM, Olof Johansson <olof@lixom•net> wrote:
>> On Mon, Nov 19, 2012 at 01:39:04PM +0000, Pawel Moll wrote:
>>> As the current LEDs code breaks other platform, remove it.
>>>
>>> It shall be replaced by a generic "MMIO LEDs" driver.
>>>
>>> Reported-by: Stephen Warren <swarren@wwwdotorg•org>
>>> Signed-off-by: Pawel Moll <pawel.moll@arm•com>
>>> ---
>>> drivers/mfd/vexpress-sysreg.c | 77 -----------------------------------------
>>> 1 file changed, 77 deletions(-)
>>>
>>> Hi Arnd,
>>>
>>> As I haven't managed to get any feedback on the generic MMIO
>>> LEDs driver so far, I have to postpone it till next cycle and
>>> completely remove the LED-related code from the vexpress-sysreg
>>> driver, as it breaks other platforms today.
>>>
>>> Would you be so kind to apply this patch, please? Alternatively
>>> you can pull it from here:
>>>
>>> git://git.linaro.org/people/pawelmoll/linux.git vexpress-soc2
>>>
>>> (this branch is based on the vexpress-soc you already have)
>>
>> Applied the patch on top of vexpress/soc, and merged in that branch into
>> next/soc again (it had been reverted due to the issues)
>
> Actually, I replaced our current vexpress/soc with the latest one you
> had sent a pull request from before, since it had the appropriate
> dependencies with the clock tree sorted out
> (git://git.linaro.org/people/pawelmoll/linux.git vexpress-clk-soc).
In next-20121127, I still see that drivers/mfd/vexpress-sysreg.c has the
following code:
> static int __init vexpress_sysreg_init_leds(void)
> {
> struct vexpress_sysreg_led *led;
> int i;
>
> /* Clear all user LEDs */
> writel(0, vexpress_sysreg_base + SYS_LED);
...
> }
> device_initcall(vexpress_sysreg_init_leds);
... and on systems where vexpress_sysreg_base is not set, this crashes
the kernel on boot.
Shouldn't the patch "mfd: vexpress-sysreg: Remove LEDs code" be applied
to solve this?
next prev parent reply other threads:[~2012-11-27 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 13:39 [PATCH] mfd: vexpress-sysreg: Remove LEDs code Pawel Moll
2012-11-19 19:07 ` Stephen Warren
2012-11-21 8:55 ` Olof Johansson
2012-11-21 9:04 ` Olof Johansson
2012-11-27 18:00 ` Stephen Warren [this message]
2012-11-28 11:38 ` Pawel Moll
2012-12-08 0:35 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B4FFB2.6050601@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox