From: arend@broadcom•com (Arend van Spriel)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0/6] drivers: convert struct spinlock to spinlock_t
Date: Fri, 30 Nov 2012 09:38:26 +0100 [thread overview]
Message-ID: <50B87082.3020604@broadcom.com> (raw)
In-Reply-To: <1354221910-22493-1-git-send-email-mcgrof@do-not-panic.com>
On 11/29/2012 09:45 PM, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@do-not-panic•com>
>
> Turns out a few drivers have strayed away from using the
> spinlock_t typedef and decided to use struct spinlock
> directly. This series converts these drivers to use
> spinlock_t. Each change has been compile tested with
> allmodconfig and sparse checked. Driver developers
> may want to look at the compile error output / sparse
> error report supplied in each commit log, in particular
> brcmfmac and i915, there are quite a few things that
> are not related to this change that the developers
> can clean up / fix.
So what is the rationale here. During mainlining our drivers we had to
remove all uses of 'typedef struct foo foo_t;'. The Linux CodingStyle
(chapter 5 Typedefs) is spending a number of lines explaining why.
So is spinlock_t an exception to this rule simply because the kernel
uses spinlock_t all over the place. Using Greg's favorite final email
remark:
Confused.
Gr. AvS
> Luis R. Rodriguez (6):
> ux500: convert struct spinlock to spinlock_t
> i915: convert struct spinlock to spinlock_t
> s5p-fimc: convert struct spinlock to spinlock_t
> s5p-jpeg: convert struct spinlock to spinlock_t
> brcmfmac: convert struct spinlock to spinlock_t
> ie6xx_wdt: convert struct spinlock to spinlock_t
>
> drivers/crypto/ux500/cryp/cryp.h | 4 ++--
> drivers/crypto/ux500/hash/hash_alg.h | 4 ++--
> drivers/gpu/drm/i915/i915_drv.h | 4 ++--
> drivers/media/platform/s5p-fimc/mipi-csis.c | 2 +-
> drivers/media/platform/s5p-jpeg/jpeg-core.h | 2 +-
> drivers/net/wireless/brcm80211/brcmfmac/fweh.h | 2 +-
> drivers/watchdog/ie6xx_wdt.c | 2 +-
> 7 files changed, 10 insertions(+), 10 deletions(-)
>
next prev parent reply other threads:[~2012-11-30 8:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 20:45 [PATCH 0/6] drivers: convert struct spinlock to spinlock_t Luis R. Rodriguez
2012-11-29 20:45 ` [PATCH 1/6] ux500: " Luis R. Rodriguez
2012-12-01 18:11 ` Linus Walleij
2012-11-29 20:45 ` [PATCH 2/6] i915: " Luis R. Rodriguez
2012-11-29 20:49 ` Daniel Vetter
2012-11-29 20:45 ` [PATCH 3/6] s5p-fimc: " Luis R. Rodriguez
2012-11-29 20:45 ` [PATCH 4/6] s5p-jpeg: " Luis R. Rodriguez
2012-11-29 20:45 ` [PATCH 5/6] brcmfmac: " Luis R. Rodriguez
2012-11-29 20:45 ` [PATCH 6/6] ie6xx_wdt: " Luis R. Rodriguez
2012-11-30 8:38 ` Arend van Spriel [this message]
2012-11-30 19:18 ` [PATCH 0/6] drivers: " Luis R. Rodriguez
2012-11-30 20:25 ` Luis R. Rodriguez
2012-11-30 21:21 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B87082.3020604@broadcom.com \
--to=arend@broadcom$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox