From: armando.visconti@st•com (Armando Visconti)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] nommu: Enable the strict alignment (CR_A) bit only if ARCH < v6
Date: Tue, 4 Dec 2012 10:36:55 +0100 [thread overview]
Message-ID: <50BDC437.1050701@st.com> (raw)
In-Reply-To: <20121203174617.GL20074@mudshark.cambridge.arm.com>
On 12/03/2012 06:46 PM, Will Deacon wrote:
> On Mon, Dec 03, 2012 at 05:25:53PM +0000, Russell King - ARM Linux wrote:
>> On Mon, Dec 03, 2012 at 05:44:11PM +0100, Armando Visconti wrote:
>>> On 11/29/2012 12:04 PM, Armando VISCONTI wrote:
>>>> This patch keeps disabled the strict alignment CP15 bit for
>>>> all armv6 and armv7 processor without the mmu. This behaviour
>>>> is now same as in the mmu case.
>>>>
>>>> Signed-off-by: Armando Visconti<armando.visconti@st•com>
>>>> ---
>>>> arch/arm/kernel/head-nommu.S | 2 +-
>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/arch/arm/kernel/head-nommu.S b/arch/arm/kernel/head-nommu.S
>>>> index 278cfc1..2c228a0 100644
>>>> --- a/arch/arm/kernel/head-nommu.S
>>>> +++ b/arch/arm/kernel/head-nommu.S
>>>> @@ -68,7 +68,7 @@ __after_proc_init:
>>>> * CP15 system control register value returned in r0 from
>>>> * the CPU init function.
>>>> */
>>>> -#ifdef CONFIG_ALIGNMENT_TRAP
>>>> +#if defined(CONFIG_ALIGNMENT_TRAP)&& __LINUX_ARM_ARCH__< 6
>>>> orr r0, r0, #CR_A
>>>> #else
>>>> bic r0, r0, #CR_A
>>>
>>> Any feedback on this simple patch?
>>
>> Well, it brings the nommu version into line with the mmu version, so
>> it's sensible. Please put it in the patch system, thanks.
>
Done!
> In which case, I'll definitely dust-off the patches to prevent unaligned
> accesses to strongly-ordered memory because that results in good ol'
> UNPREDICTABLE behaviour.
>
Yes, we definetely need them.
Thx,
Arm
next prev parent reply other threads:[~2012-12-04 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 11:04 [PATCH] nommu: Enable the strict alignment (CR_A) bit only if ARCH < v6 Armando Visconti
2012-12-03 16:44 ` Armando Visconti
2012-12-03 16:51 ` Nicolas Pitre
2012-12-03 16:54 ` Will Deacon
2012-12-03 17:25 ` Russell King - ARM Linux
2012-12-03 17:46 ` Will Deacon
2012-12-04 9:36 ` Armando Visconti [this message]
2012-12-05 19:51 ` Uwe Kleine-König
2012-12-06 10:47 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BDC437.1050701@st.com \
--to=armando.visconti@st$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox