From: swarren@wwwdotorg•org (Stephen Warren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 2/6] ARM: tegra20: cpuidle: add powered-down state for secondary CPU
Date: Thu, 06 Dec 2012 11:56:19 -0700 [thread overview]
Message-ID: <50C0EA53.6010504@wwwdotorg.org> (raw)
In-Reply-To: <1354782322.13857.78.camel@jlo-ubuntu-64.nvidia.com>
On 12/06/2012 01:25 AM, Joseph Lo wrote:
> On Wed, 2012-12-05 at 18:50 +0800, Lorenzo Pieralisi wrote:
>> On Wed, Dec 05, 2012 at 10:01:49AM +0000, Joseph Lo wrote:
>>> static struct cpuidle_driver tegra_idle_driver = {
>>> .name = "tegra_idle",
>>> .owner = THIS_MODULE,
>>> .en_core_tk_irqen = 1,
>>> +#ifdef CONFIG_PM_SLEEP
>>> + .state_count = 2,
>>> +#else
>>> .state_count = 1,
>>> +#endif
>>
>> These hardcoded values are not nice.
>>
> OK. I will change it to runtime detection when idle driver registration.
Personally, I find doing this at compile-time much better; the
conditional definition of state_count is right next to the conditional
setup of the array whose size it defines. Assigning state_count at
run-time ense up moving the two pieces of logic apart, which seems
likely to cause more issues...
>>> .states = {
>>> [0] = ARM_CPUIDLE_WFI_STATE_PWR(600),
>>> +#ifdef CONFIG_PM_SLEEP
>>> + [1] = {
>>> + .enter = tegra20_idle_lp2,
>>> + .exit_latency = 5000,
>>> + .target_residency = 10000,
>>> + .power_usage = 0,
>>> + .flags = CPUIDLE_FLAG_TIME_VALID,
>>> + .name = "powered-down",
>>> + .desc = "CPU power gated",
>>> + },
>>> +#endif
>>> },
>>> };
next prev parent reply other threads:[~2012-12-06 18:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 10:01 [PATCH V2 0/6] ARM: tegra20: cpuidle: add power-down state Joseph Lo
2012-12-05 10:01 ` [PATCH V2 1/6] ARM: tegra: add pending SGI checking API Joseph Lo
2012-12-05 22:09 ` Stephen Warren
2012-12-06 7:04 ` Joseph Lo
2012-12-06 18:52 ` Stephen Warren
2012-12-05 10:01 ` [PATCH V2 2/6] ARM: tegra20: cpuidle: add powered-down state for secondary CPU Joseph Lo
2012-12-05 10:50 ` Lorenzo Pieralisi
2012-12-06 8:25 ` Joseph Lo
2012-12-06 18:56 ` Stephen Warren [this message]
2013-01-11 7:20 ` Joseph Lo
2013-01-11 12:24 ` Lorenzo Pieralisi
2013-01-15 3:00 ` Joseph Lo
2013-01-15 11:34 ` Lorenzo Pieralisi
2013-01-16 3:17 ` Joseph Lo
2013-01-12 17:33 ` Nicolas Pitre
2012-12-05 22:18 ` Stephen Warren
2012-12-06 7:22 ` Joseph Lo
2012-12-06 18:59 ` Stephen Warren
2012-12-05 10:01 ` [PATCH V2 3/6] ARM: tegra20: clocks: add CPU low-power function into tegra_cpu_car_ops Joseph Lo
2012-12-05 10:01 ` [PATCH V2 4/6] ARM: tegra20: flowctrl: add support for cpu_suspend_enter/exit Joseph Lo
2012-12-05 10:01 ` [PATCH V2 5/6] ARM: tegra20: cpuidle: add powered-down state for CPU0 Joseph Lo
2012-12-05 10:01 ` [PATCH V2 6/6] ARM: tegra20: cpuidle: apply coupled cpuidle for powered-down mode Joseph Lo
2012-12-05 10:01 ` Joseph Lo
2012-12-05 10:10 ` Joseph Lo
2012-12-06 11:03 ` Grant Likely
2012-12-05 10:01 ` Joseph Lo
2012-12-05 10:11 ` Joseph Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C0EA53.6010504@wwwdotorg.org \
--to=swarren@wwwdotorg$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox