From: nsekhar@ti•com (Sekhar Nori)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/3] mtd: nand: omap2: Update nerrors using ecc.strength
Date: Fri, 7 Dec 2012 16:10:04 +0530 [thread overview]
Message-ID: <50C1C784.4040209@ti.com> (raw)
In-Reply-To: <518397C60809E147AF5323E0420B992E3EA1139B@DBDE01.ent.ti.com>
On 12/5/2012 6:13 PM, Philip, Avinash wrote:
> On Wed, Dec 05, 2012 at 17:33:37, Nori, Sekhar wrote:
>> Hi Avinash,
>>
>> On 11/29/2012 5:16 PM, Philip, Avinash wrote:
>>> Update number of errors using nand ecc strength.
>>> Also add macro definitions BCH8_ERROR_MAX & BCH4_ERROR_MAX
>>
>> Can you please describe why the original method of setting nerrors was
>> incorrect? Was it causing any issues in any particular configuration?
>
> It affects the reusability of the code. For example BCH8 with AM335x RBL
> compatibility requires 14 bytes instead of 13 byte. So setting nerrors
> with
> nerrors = (info->nand.ecc.bytes == 13) ? 8 : 4;
> will break am335x RBL compatibility.
This should be summarized in the patch description so the motivation is
clear to those who read the history later.
Thanks,
Sekhar
next prev parent reply other threads:[~2012-12-07 10:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 11:46 [PATCH v3 0/3] mtd: nand: OMAP: ELM error correction support for BCH ecc Philip, Avinash
2012-11-29 11:46 ` [PATCH v3 1/3] mtd: nand: omap2: Update nerrors using ecc.strength Philip, Avinash
2012-12-05 12:03 ` Sekhar Nori
2012-12-05 12:43 ` Philip, Avinash
2012-12-07 10:40 ` Sekhar Nori [this message]
2012-12-10 6:44 ` Philip, Avinash
2012-11-29 11:46 ` [PATCH v3 2/3] mtd: devices: elm: Add support for ELM error correction Philip, Avinash
2012-12-07 10:37 ` Sekhar Nori
2012-12-10 6:43 ` Philip, Avinash
2012-12-12 11:15 ` Sekhar Nori
2012-12-11 9:03 ` Grant Likely
2012-12-11 12:55 ` Philip, Avinash
2012-11-29 11:46 ` [PATCH v3 3/3] mtd: nand: omap2: Support for hardware BCH " Philip, Avinash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C1C784.4040209@ti.com \
--to=nsekhar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox