From: csd@broadcom•com (Christian Daudt)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2] ARM: bcm281xx: Add timer driver
Date: Tue, 11 Dec 2012 09:39:02 -0800 [thread overview]
Message-ID: <50C76FB6.5040306@broadcom.com> (raw)
In-Reply-To: <50C63285.1030605@us.ibm.com>
On 12-12-10 11:05 AM, John Stultz wrote:
>
> But since you pulled me in here, I've got a bike-shedding nit below
> (Sorry!).
>
>>> diff --git a/drivers/clocksource/bcm_kona_timer.c
>>> b/drivers/clocksource/bcm_kona_timer.c
>>> new file mode 100644
>>> index 0000000..dbc54c2
>>> --- /dev/null
>>> +++ b/drivers/clocksource/bcm_kona_timer.c
>>>
>>> +static void __init timers_init(void)
>>> +static int timer_set_next_event(unsigned long clc,
>>> + struct clock_event_device *unused)
>>> +static void timer_set_mode(enum clock_event_mode mode,
>>> + struct clock_event_device *unused)
>>> +static void __init timer_clockevents_init(void)
>>>
>>> +static irqreturn_t timer_interrupt(int irq, void *dev_id)
>>>
>
> These are all terribly generic function names. I know they're static
> (and plenty of other driver do the same thing), but it makes grepping
> for similar code a pain and can cause confusing backtraces. Maybe
> consider using the kona_timer_... prefix?
>
Fair enough. I've slapped kona_ in front of all the funcs+vars that
previously did not have it. V3 coming out soon.
Thanks,
csd
> Other then that, for what its worth,
> Acked-by: John Stultz <johnstul@us•ibm.com>
>
> thanks
> -john
>
>
prev parent reply other threads:[~2012-12-11 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-08 8:15 [PATCH V2] ARM: bcm281xx: Add timer driver Christian Daudt
2012-12-08 23:44 ` Olof Johansson
2012-12-10 19:05 ` John Stultz
2012-12-11 17:39 ` Christian Daudt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C76FB6.5040306@broadcom.com \
--to=csd@broadcom$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox