From: mikedunn@newsguy•com (Mike Dunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/3] ARM: pxa: palmtreo: fix #ifdefs for leds-gpio device
Date: Sun, 23 Dec 2012 07:10:02 -0800 [thread overview]
Message-ID: <50D71ECA.6080005@newsguy.com> (raw)
In-Reply-To: <201212230420.55725.marex@denx.de>
On 12/22/2012 07:20 PM, Marek Vasut wrote:
> Dear Mike Dunn,
>
>> The #ifdefs around the leds-gpio device platform data are erroneous.
>> Currently the device is not instantiated on the centro unless
>> CONFIG_MACH_TREO680 is defined.
>>
>> Signed-off-by: Mike Dunn <mikedunn@newsguy•com>
>> ---
>>
>> The #ifdefs within palmtreo_leds_init() are a little ugly, but I think the
>> only alternative would be to instantiate the leds-gpio device platform
>> data for both treo680 and centro, which would require some of the #defines
>> in palmtreo.h to be moved outside their containing #ifdef
>> CONFIG_MACH_{TREO680,CENTRO}.
>
> Shall we not just kill all those ifdefs and let GCC decide what to optimize out?
> I think this kind of simple stuff should just be optimized out anyway.
You're suggesting that all the #ifdef CONFIG_MACH_{TREO680,CENTRO} be removed
from palmtreo.h? Yes, this might be better. I'll look into it.
Thanks again,
Mike
next prev parent reply other threads:[~2012-12-23 15:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-22 19:31 [PATCH 0/3] ARM: pxa: palmtreo: a few treo fixes Mike Dunn
2012-12-22 19:31 ` [PATCH 1/3] ARM: pxa: palmtreo: fix lcd initialization on treo680 Mike Dunn
2012-12-23 3:18 ` Marek Vasut
2012-12-23 14:59 ` Mike Dunn
2012-12-22 19:31 ` [PATCH 2/3] ARM: pxa: palmtreo: fix #ifdefs for leds-gpio device Mike Dunn
2012-12-23 3:20 ` Marek Vasut
2012-12-23 15:10 ` Mike Dunn [this message]
2012-12-22 19:31 ` [PATCH 3/3] ARM: pxa: palmtreo: add docg4 device initialization Mike Dunn
2012-12-23 3:21 ` Marek Vasut
2012-12-23 14:11 ` Sergei Shtylyov
2012-12-23 15:18 ` Mike Dunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50D71ECA.6080005@newsguy.com \
--to=mikedunn@newsguy$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox