From: sshtylyov@mvista•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller
Date: Thu, 03 Jan 2013 15:26:37 +0400 [thread overview]
Message-ID: <50E56AED.1000509@mvista.com> (raw)
In-Reply-To: <50E52D26.9010004@denx.de>
Hello.
On 03-01-2013 11:03, Heiko Schocher wrote:
>>> add OF support for the davinci nand controller.
>>> Signed-off-by: Heiko Schocher<hs@denx•de>
>>> Cc: davinci-linux-open-source at linux.davincidsp.com
>>> Cc: linux-arm-kernel at lists.infradead.org
>>> Cc: devicetree-discuss at lists.ozlabs.org
>>> Cc: linux-mtd at lists.infradead.org
>>> Cc: David Woodhouse<dwmw2@infradead•org>
>>> Cc: Grant Likely<grant.likely@secretlab•ca>
>>> Cc: Sekhar Nori<nsekhar@ti•com>
>>> Cc: Wolfgang Denk<wd@denx•de>
>>> Cc: Scott Wood<scottwood@freescale•com>
>> [...]
>>> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
>>> index d94b03c..f386b3c 100644
>>> --- a/drivers/mtd/nand/davinci_nand.c
>>> +++ b/drivers/mtd/nand/davinci_nand.c
>> [...]
>>> @@ -518,9 +519,75 @@ static struct nand_ecclayout hwecc4_2048 __initconst = {
>>> },
>>> };
>>> +#if defined(CONFIG_OF)
>>> +static const struct of_device_id davinci_nand_of_match[] = {
>>> + {.compatible = "ti,davinci-nand", },
>>> + {},
>>> +}
>> I have only one question: have you ever try to compile this patch with
>> CONFIG_OF enabled? If you have, you would have noticed:
>> drivers/mtd/nand/davinci_nand.c:527: error: expected ?,? or ?;? before ?extern?
>>> +MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
> Hmm.. maybe this crept in later after I sent the patches? They were
> pending for a while ... I compiled it just yet again (based on my
> tree when I posted this patch based on commit:
I've just checked the archives: every patch version you posted had ';'
after '}' missing.
WBR, Sergei
next prev parent reply other threads:[~2013-01-03 11:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 7:22 [PATCH v6] ARM: mtd: nand: davinci: add OF support for davinci nand controller Heiko Schocher
2012-08-07 14:34 ` Heiko Schocher
2012-08-07 17:36 ` Sekhar Nori
2012-08-23 15:34 ` Artem Bityutskiy
2013-01-02 19:43 ` Sergei Shtylyov
2013-01-03 7:03 ` Heiko Schocher
2013-01-03 11:26 ` Sergei Shtylyov [this message]
2013-01-03 11:32 ` David Woodhouse
2013-01-03 11:39 ` Sergei Shtylyov
2013-01-03 17:56 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E56AED.1000509@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox